From: Robert Schwebel <r.schwebel@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ibrdtn: add packaging rules for IBR-DTN and dtndht
Date: Thu, 25 Aug 2016 17:11:50 +0200 [thread overview]
Message-ID: <20160825151150.ymohz3iyyjsa6ai4@pengutronix.de> (raw)
In-Reply-To: <20160825110203.3d5to6ukfgdleza3@pengutronix.de>
On Thu, Aug 25, 2016 at 01:02:03PM +0200, Michael Olbrich wrote:
> On Tue, Aug 23, 2016 at 06:41:40AM +0200, Roland Hieber wrote:
> > On 18.08.2016 08:53, Michael Olbrich wrote:
> > > And check your configure options. You need to specify everything that is
> > > optional or may be auto detected. Please look at some other rules for
> > > guidance or ask me if you are unsure if an option should be specified.
> >
> > Uh, good point. Most of the --disable/--enable options seem to be built
> > in a way that their state is autodetected, except when overwritten on
> > the command line. But not for every --disable there is also a matching
> > --enable (that would let the configure fail if things are wrong)!
> >
> > For example, in ibrcommon, only --disable-netlink really works and
> > disables netlink support, but --enable-netlink also disables netlink
> > support, because AC_ARG_ENABLE only checks for the existence of the
> > --*-netlink switches, not for their actual value. [0]
>
> Right, broken configure.ac :-/. Use this:
>
> $(call ptx/ifdef,PTXCONF_FOO,,--disable-netlink)
And, even better, send a patch to upstream and fix it :-)
rsc
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2016-08-25 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 14:53 Roland Hieber
2016-08-18 6:53 ` Michael Olbrich
2016-08-23 4:41 ` Roland Hieber
2016-08-25 11:02 ` Michael Olbrich
2016-08-25 15:11 ` Robert Schwebel [this message]
2016-08-28 5:27 ` Roland Hieber
2016-08-28 7:36 ` Robert Schwebel
2016-08-28 18:36 ` Roland Hieber
2016-09-01 9:58 ` Michael Olbrich
2016-09-01 15:09 ` Alexander Dahl
2016-08-29 7:42 ` Juergen Borleis
2016-08-18 10:15 ` Michael Olbrich
2016-08-28 5:32 ` [ptxdist] [PATCH v2] " Roland Hieber
2016-09-07 13:48 ` Michael Olbrich
2016-09-08 1:07 ` Roland Hieber
2016-09-08 6:35 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825151150.ymohz3iyyjsa6ai4@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox