* [ptxdist] timezone: avoid shell error "[: too many arguments'
@ 2016-07-26 14:10 Juergen Borleis
2016-07-27 11:02 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Borleis @ 2016-07-26 14:10 UTC (permalink / raw)
To: ptxdist
Using it in one string lets scripts/make_zoneinfo.sh complain with:
line 50: [: too many arguments
Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
diff --git a/rules/timezone.make b/rules/timezone.make
index 89227c314c18..1aeb8f35fa68 100644
--- a/rules/timezone.make
+++ b/rules/timezone.make
@@ -30,7 +30,9 @@ TIMEZONE-$(PTXCONF_TIMEZONE_EUROPE) += "Europe"
TIMEZONE-$(PTXCONF_TIMEZONE_EST5EDT) += "EST5EDT"
TIMEZONE-$(PTXCONF_TIMEZONE_CANADA) += "Canada"
TIMEZONE-$(PTXCONF_TIMEZONE_FACTORY) += "Factory"
-TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0 GMT0 GMT+0"
+TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0"
+TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT0"
+TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT+0"
TIMEZONE-$(PTXCONF_TIMEZONE_ICELAND) += "Iceland"
TIMEZONE-$(PTXCONF_TIMEZONE_JAPAN) += "Japan"
TIMEZONE-$(PTXCONF_TIMEZONE_MST7MDT) += "MST7MDT"
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [ptxdist] timezone: avoid shell error "[: too many arguments'
2016-07-26 14:10 [ptxdist] timezone: avoid shell error "[: too many arguments' Juergen Borleis
@ 2016-07-27 11:02 ` Michael Olbrich
2016-07-27 12:03 ` Juergen Borleis
0 siblings, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2016-07-27 11:02 UTC (permalink / raw)
To: ptxdist
On Tue, Jul 26, 2016 at 04:10:01PM +0200, Juergen Borleis wrote:
> Using it in one string lets scripts/make_zoneinfo.sh complain with:
>
> line 50: [: too many arguments
>
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
>
> diff --git a/rules/timezone.make b/rules/timezone.make
> index 89227c314c18..1aeb8f35fa68 100644
> --- a/rules/timezone.make
> +++ b/rules/timezone.make
> @@ -30,7 +30,9 @@ TIMEZONE-$(PTXCONF_TIMEZONE_EUROPE) += "Europe"
> TIMEZONE-$(PTXCONF_TIMEZONE_EST5EDT) += "EST5EDT"
> TIMEZONE-$(PTXCONF_TIMEZONE_CANADA) += "Canada"
> TIMEZONE-$(PTXCONF_TIMEZONE_FACTORY) += "Factory"
> -TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0 GMT0 GMT+0"
> +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0"
> +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT0"
> +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT+0"
I think this is just a quoting problem. Keep it in one line:
TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0" "GMT0" "GMT+0"
Michael
> TIMEZONE-$(PTXCONF_TIMEZONE_ICELAND) += "Iceland"
> TIMEZONE-$(PTXCONF_TIMEZONE_JAPAN) += "Japan"
> TIMEZONE-$(PTXCONF_TIMEZONE_MST7MDT) += "MST7MDT"
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] timezone: avoid shell error "[: too many arguments'
2016-07-27 11:02 ` Michael Olbrich
@ 2016-07-27 12:03 ` Juergen Borleis
2016-07-27 12:05 ` [ptxdist] [PATCH v2] " Juergen Borleis
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Borleis @ 2016-07-27 12:03 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Olbrich
Hi Michael,
On Wednesday 27 July 2016 13:02:10 Michael Olbrich wrote:
> On Tue, Jul 26, 2016 at 04:10:01PM +0200, Juergen Borleis wrote:
> > Using it in one string lets scripts/make_zoneinfo.sh complain with:
> >
> > line 50: [: too many arguments
> >
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> >
> > diff --git a/rules/timezone.make b/rules/timezone.make
> > index 89227c314c18..1aeb8f35fa68 100644
> > --- a/rules/timezone.make
> > +++ b/rules/timezone.make
> > @@ -30,7 +30,9 @@ TIMEZONE-$(PTXCONF_TIMEZONE_EUROPE) += "Europe"
> > TIMEZONE-$(PTXCONF_TIMEZONE_EST5EDT) += "EST5EDT"
> > TIMEZONE-$(PTXCONF_TIMEZONE_CANADA) += "Canada"
> > TIMEZONE-$(PTXCONF_TIMEZONE_FACTORY) += "Factory"
> > -TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0 GMT0 GMT+0"
> > +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0"
> > +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT0"
> > +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT+0"
>
> I think this is just a quoting problem. Keep it in one line:
>
> TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0" "GMT0" "GMT+0"
You're right. Will send a changed patch soon.
jb
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ptxdist] [PATCH v2] timezone: avoid shell error "[: too many arguments'
2016-07-27 12:03 ` Juergen Borleis
@ 2016-07-27 12:05 ` Juergen Borleis
0 siblings, 0 replies; 4+ messages in thread
From: Juergen Borleis @ 2016-07-27 12:05 UTC (permalink / raw)
To: ptxdist
Using it in one string breaks quoting and lets scripts/make_zoneinfo.sh
fail with:
line 50: [: too many arguments
Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
diff --git a/rules/timezone.make b/rules/timezone.make
index 89227c314c18..df97b9451054 100644
--- a/rules/timezone.make
+++ b/rules/timezone.make
@@ -30,7 +30,7 @@ TIMEZONE-$(PTXCONF_TIMEZONE_EUROPE) += "Europe"
TIMEZONE-$(PTXCONF_TIMEZONE_EST5EDT) += "EST5EDT"
TIMEZONE-$(PTXCONF_TIMEZONE_CANADA) += "Canada"
TIMEZONE-$(PTXCONF_TIMEZONE_FACTORY) += "Factory"
-TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0 GMT0 GMT+0"
+TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0" "GMT0" "GMT+0"
TIMEZONE-$(PTXCONF_TIMEZONE_ICELAND) += "Iceland"
TIMEZONE-$(PTXCONF_TIMEZONE_JAPAN) += "Japan"
TIMEZONE-$(PTXCONF_TIMEZONE_MST7MDT) += "MST7MDT"
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-27 12:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-26 14:10 [ptxdist] timezone: avoid shell error "[: too many arguments' Juergen Borleis
2016-07-27 11:02 ` Michael Olbrich
2016-07-27 12:03 ` Juergen Borleis
2016-07-27 12:05 ` [ptxdist] [PATCH v2] " Juergen Borleis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox