From: Juergen Borleis <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: Re: [ptxdist] timezone: avoid shell error "[: too many arguments'
Date: Wed, 27 Jul 2016 14:03:24 +0200 [thread overview]
Message-ID: <201607271403.24287.jbe@pengutronix.de> (raw)
In-Reply-To: <20160727110210.GE31919@pengutronix.de>
Hi Michael,
On Wednesday 27 July 2016 13:02:10 Michael Olbrich wrote:
> On Tue, Jul 26, 2016 at 04:10:01PM +0200, Juergen Borleis wrote:
> > Using it in one string lets scripts/make_zoneinfo.sh complain with:
> >
> > line 50: [: too many arguments
> >
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> >
> > diff --git a/rules/timezone.make b/rules/timezone.make
> > index 89227c314c18..1aeb8f35fa68 100644
> > --- a/rules/timezone.make
> > +++ b/rules/timezone.make
> > @@ -30,7 +30,9 @@ TIMEZONE-$(PTXCONF_TIMEZONE_EUROPE) += "Europe"
> > TIMEZONE-$(PTXCONF_TIMEZONE_EST5EDT) += "EST5EDT"
> > TIMEZONE-$(PTXCONF_TIMEZONE_CANADA) += "Canada"
> > TIMEZONE-$(PTXCONF_TIMEZONE_FACTORY) += "Factory"
> > -TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0 GMT0 GMT+0"
> > +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0"
> > +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT0"
> > +TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT+0"
>
> I think this is just a quoting problem. Keep it in one line:
>
> TIMEZONE-$(PTXCONF_TIMEZONE_GMT0) += "GMT-0" "GMT0" "GMT+0"
You're right. Will send a changed patch soon.
jb
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2016-07-27 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 14:10 Juergen Borleis
2016-07-27 11:02 ` Michael Olbrich
2016-07-27 12:03 ` Juergen Borleis [this message]
2016-07-27 12:05 ` [ptxdist] [PATCH v2] " Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201607271403.24287.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox