Re: [ptxdist] [BUG] error: empty parameter to 'ptxd_make_get'

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jul 01, 2016 at 10:41:10AM +0200, Ladislav Michl wrote:
> On Thu, Jun 30, 2016 at 04:04:20PM +0200, Michael Olbrich wrote:
> > I can't reproduce this here. Can you please create a file like this:
> > 
> > $ cat rules/post/zzz.make
> > foo:
> > 	echo $(PTXCONF_HOST_GETTEXT)
> > 	echo $(HOST_GETTEXT_SOURCE)
> > 	echo $($(HOST_GETTEXT_SOURCE))
> > 
> > And then call:
> > $ ptxdist make foo
> > 
> > What do you get?
> 
> I extended it a bit:
> $ cat rules/post/zzz.make
> foo:
>         echo $(PTXCONF_HOST_GETTEXT)
>         echo $(HOST_GETTEXT_SOURCE)
>         echo $($(HOST_GETTEXT_SOURCE))
>         echo $(PTXCONF_HOST_ACL)
>         echo $(HOST_ACL_SOURCE)
>         echo $($(HOST_ACL_SOURCE))
>         echo $(PTXCONF_HOST_NCURSES)
>         echo $(HOST_NCURSES_SOURCE)
>         echo $($(HOST_NCURSES_SOURCE))
> 
> $ grep -e GETTEXT -e ACL -e NCURSES < configs/ptxconfig
> PTXCONF_HOST_ACL=y
> PTXCONF_HOST_GETTEXT=m
> PTXCONF_HOST_NCURSES=m
> PTXCONF_NCURSES=m
> (output edited)

looks correct so far.

> $ ptxdist --force make foo
> echo m
> m
> echo /home/ladis/src/peoplemetr/SimEarTools/dist/src/gettext-0.19.1.tar.xz
> /home/ladis/src/peoplemetr/SimEarTools/dist/src/gettext-0.19.1.tar.xz
> echo
> 

You should get 'HOST_GETTEXT' here :-/.

> echo y
> y
> echo /home/ladis/src/peoplemetr/SimEarTools/dist/src/acl-2.2.52.src.tar.gz
> /home/ladis/src/peoplemetr/SimEarTools/dist/src/acl-2.2.52.src.tar.gz
> echo HOST_ACL
> HOST_ACL
> echo m
> m
> echo /home/ladis/src/peoplemetr/SimEarTools/dist/src/ncurses-5.9.tar.gz
> /home/ladis/src/peoplemetr/SimEarTools/dist/src/ncurses-5.9.tar.gz
> echo NCURSES
> NCURSES

This is strange. With ncurses and host-ncurses selected, I would have
expected HOST_NCURSES here.

Can you make this change:

diff --git a/rules/post/ptxd_make_world_get.make b/rules/post/ptxd_make_world_get.make
index 142d672f74c3..6405263fad6b 100644
--- a/rules/post/ptxd_make_world_get.make
+++ b/rules/post/ptxd_make_world_get.make
@@ -14,7 +14,7 @@
 # $(<PKG>_SOURCE) := <PKG>
 #
 define pkg_source
-$(if $($(1)_SOURCE),$(eval $($(1)_SOURCE) := $(1)),)
+$(if $($(1)_SOURCE),$(eval $(warning $($(1)_SOURCE) := $(1))),)
 endef
 $(foreach pkg, $(PTX_PACKAGES_SELECTED), $(call pkg_source,$(PTX_MAP_TO_PACKAGE_$(pkg))))
 

... and then run 'ptxdist make foo' again? It will break things, so the
last echo for all 3 cases will print nothing but you should get a list of
warnings. Send that list please.
And the output of "ptxdist print PTX_PACKAGES_SELECTED".

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de