Re: [ptxdist] [PATCH] mmc-utils: add new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Jun 14, 2016 at 11:41:39AM +0200, Matthias Klein wrote:
> This tool allows to configure the eMMC user data area for enhanced mode (pseudo-SLC)
> 
> Signed-off-by: Matthias Klein <matthias.klein@optimeas.de>
> ---
>  rules/mmc-utils.in   |  8 ++++++++
>  rules/mmc-utils.make | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 63 insertions(+)
>  create mode 100644 rules/mmc-utils.in
>  create mode 100644 rules/mmc-utils.make
> 
> diff --git a/rules/mmc-utils.in b/rules/mmc-utils.in
> new file mode 100644
> index 0000000..b053d9d
> --- /dev/null
> +++ b/rules/mmc-utils.in
> @@ -0,0 +1,8 @@
> +## SECTION=disk_and_file
> +config MMC_UTILS
> +	tristate
> +	prompt "mmc-utils"
> +	help
> +	  mmc-utils is a tool for configuring MMC storage devices from userspace
> +
> +	  See https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/Documentation/mmc/mmc-tools.txt for details.
> diff --git a/rules/mmc-utils.make b/rules/mmc-utils.make
> new file mode 100644
> index 0000000..8e20966
> --- /dev/null
> +++ b/rules/mmc-utils.make
> @@ -0,0 +1,55 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2016 by Matthias Klein <matthias.klein@optimeas.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MMC_UTILS) += mmc-utils
> +
> +#
> +# Paths and names
> +#
> +MMC_UTILS_VERSION	:= 2016-06-07
> +MMC_UTILS_MD5		:= 429e6eb921046d6634ac310bc465065a
> +MMC_UTILS		:= mmc-utils-$(MMC_UTILS_VERSION)
> +MMC_UTILS_SUFFIX	:= tar.gz
> +MMC_UTILS_URL		:= git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;tag=0ca049f25191c32323ba25a3cfd542b9fdefb473
> +MMC_UTILS_SOURCE	:= $(SRCDIR)/$(MMC_UTILS).$(MMC_UTILS_SUFFIX)
> +MMC_UTILS_DIR		:= $(BUILDDIR)/$(MMC_UTILS)
> +MMC_UTILS_LICENSE	:= unknown

Please add the license. I've seen at least GPL-2.0 and BSD-3-Clause.

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#MMC_UTILS_PATH	:= PATH=$(CROSS_PATH)

remove.

> +MMC_UTILS_CONF_TOOL	:= NO
> +MMC_UTILS_MAKE_ENV	:= $(CROSS_ENV)

If you add prefix=/usr here....

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mmc-utils.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mmc-utils)
> +	@$(call install_fixup, mmc-utils,PRIORITY,optional)
> +	@$(call install_fixup, mmc-utils,SECTION,base)
> +	@$(call install_fixup, mmc-utils,AUTHOR,"Matthias Klein <matthias.klein@optimeas.de>")
> +	@$(call install_fixup, mmc-utils,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mmc-utils, 0, 0, 0755, $(MMC_UTILS_DIR)/mmc, /usr/bin/mmc)

... you should be able to do this:
	@$(call install_copy, mmc-utils, 0, 0, 0755, -, /usr/bin/mmc)

Michael

> +
> +	@$(call install_finish, mmc-utils)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de