[ptxdist] [PATCH] networkmanager: add missing dependency to dbus-glib

[ptxdist] [PATCH] networkmanager: add missing dependency to dbus-glib

[Robert Schwebel]

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
 rules/networkmanager.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/networkmanager.in b/rules/networkmanager.in
index 85b1e91..15859c4 100644
--- a/rules/networkmanager.in
+++ b/rules/networkmanager.in
@@ -9,6 +9,7 @@ menuconfig NETWORKMANAGER
 	select LIBC_PTHREAD
 	select LIBC_RT
 	select DBUS
+	select DBUS_GLIB
 	select DBUS_PYTHON			if NETWORKMANAGER_EXAMPLES && RUNTIME
 	select GLIB
 	select GNUTLS
-- 
2.8.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] networkmanager: add missing dependency to dbus-glib

[Ladislav Michl]

On Thu, Jun 09, 2016 at 03:11:17PM +0200, Robert Schwebel wrote:
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
>  rules/networkmanager.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/networkmanager.in b/rules/networkmanager.in
> index 85b1e91..15859c4 100644
> --- a/rules/networkmanager.in
> +++ b/rules/networkmanager.in
> @@ -9,6 +9,7 @@ menuconfig NETWORKMANAGER
>  	select LIBC_PTHREAD
>  	select LIBC_RT
>  	select DBUS
> +	select DBUS_GLIB
>  	select DBUS_PYTHON			if NETWORKMANAGER_EXAMPLES && RUNTIME
>  	select GLIB
>  	select GNUTLS

No, please. Do not add this dependency unless you verify that anything
depends on libnm-glib. It does not seem any package needs it. See here:
https://wiki.gnome.org/Projects/NetworkManager/libnm

diff --git a/rules/networkmanager.make b/rules/networkmanager.make
index e2af34bb..7decc6b 100644
--- a/rules/networkmanager.make
+++ b/rules/networkmanager.make
@@ -62,7 +62,7 @@ NETWORKMANAGER_CONF_OPT := \
 	--disable-gtk-doc-html \
 	--disable-gtk-doc-pdf \
 	--$(call ptx/wwo,PTXCONF_NETWORKMANAGER_WIRELESS)-wext \
-	--with-libnm-glib \
+	--without-libnm-glib \
 	--with-systemdsystemunitdir=/lib/systemd/system \
 	--with-hostname-persist=default \
 	--$(call ptx/wwo,PTXCONF_NETWORKMANAGER_SYSTEMD_UNIT)-systemd-journal \

Best regards,
	ladis

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] networkmanager: add missing dependency to dbus-glib

[Robert Schwebel]

On Thu, Jun 09, 2016 at 04:22:09PM +0200, Ladislav Michl wrote:
> On Thu, Jun 09, 2016 at 03:11:17PM +0200, Robert Schwebel wrote:
> > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> > ---
> >  rules/networkmanager.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/networkmanager.in b/rules/networkmanager.in
> > index 85b1e91..15859c4 100644
> > --- a/rules/networkmanager.in
> > +++ b/rules/networkmanager.in
> > @@ -9,6 +9,7 @@ menuconfig NETWORKMANAGER
> >  	select LIBC_PTHREAD
> >  	select LIBC_RT
> >  	select DBUS
> > +	select DBUS_GLIB
> >  	select DBUS_PYTHON			if NETWORKMANAGER_EXAMPLES && RUNTIME
> >  	select GLIB
> >  	select GNUTLS
> 
> No, please. Do not add this dependency unless you verify that anything
> depends on libnm-glib. It does not seem any package needs it. See here:
> https://wiki.gnome.org/Projects/NetworkManager/libnm
> 
> diff --git a/rules/networkmanager.make b/rules/networkmanager.make
> index e2af34bb..7decc6b 100644
> --- a/rules/networkmanager.make
> +++ b/rules/networkmanager.make
> @@ -62,7 +62,7 @@ NETWORKMANAGER_CONF_OPT := \
>  	--disable-gtk-doc-html \
>  	--disable-gtk-doc-pdf \
>  	--$(call ptx/wwo,PTXCONF_NETWORKMANAGER_WIRELESS)-wext \
> -	--with-libnm-glib \
> +	--without-libnm-glib \
>  	--with-systemdsystemunitdir=/lib/systemd/system \
>  	--with-hostname-persist=default \
>  	--$(call ptx/wwo,PTXCONF_NETWORKMANAGER_SYSTEMD_UNIT)-systemd-journal \

You are right, I'll update the patch.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de