[ptxdist] canutils problem on mainline kernel

[ptxdist] canutils problem on mainline kernel

[Clemens Gruber]

Hi,

it looks like the canutils from ptxdist do not work anymore with the
current mainline kernel 4.6. (Working fine on 4.5)

Did you also notice this?

I can reproduce it with the flexcan driver on an i.MX6Q board. I get out
of range errors when trying to set the bitrate.

I saw that some of you created a new project "can-utils":
https://github.com/linux-can/can-utils

Is there a replacement for the canconfig utility from canutils?

Thanks,
Clemens

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] canutils problem on mainline kernel

[Marc Kleine-Budde]

[-- Attachment #1.1.1: Type: text/plain, Size: 998 bytes --]

On 04/13/2016 03:46 PM, Clemens Gruber wrote:

> it looks like the canutils from ptxdist do not work anymore with the
> current mainline kernel 4.6. (Working fine on 4.5)
> 
> Did you also notice this?

No. What's the outout of:

    canconfig can0

> I can reproduce it with the flexcan driver on an i.MX6Q board. I get out
> of range errors when trying to set the bitrate.

There was a problem with the CAN clock on some imx in the kernel recently.

> I saw that some of you created a new project "can-utils":
> https://github.com/linux-can/can-utils
> 
> Is there a replacement for the canconfig utility from canutils?

You can use the "ip" tool from iproute2 (not the one from busybox).

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] canutils problem on mainline kernel

[Marc Kleine-Budde]

[-- Attachment #1.1.1: Type: text/plain, Size: 605 bytes --]

On 04/13/2016 03:52 PM, Marc Kleine-Budde wrote:
>> I can reproduce it with the flexcan driver on an i.MX6Q board. I get out
>> of range errors when trying to set the bitrate.
> 
> There was a problem with the CAN clock on some imx in the kernel recently.

You probably need:
https://lkml.org/lkml/2016/3/30/299

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] canutils problem on mainline kernel

[Marc Kleine-Budde]

[-- Attachment #1.1.1: Type: text/plain, Size: 835 bytes --]

On 04/13/2016 03:46 PM, Clemens Gruber wrote:
> Hi,
> 
> it looks like the canutils from ptxdist do not work anymore with the
> current mainline kernel 4.6. (Working fine on 4.5)
> 
> Did you also notice this?
> 
> I can reproduce it with the flexcan driver on an i.MX6Q board. I get out
> of range errors when trying to set the bitrate.
> 
> I saw that some of you created a new project "can-utils":
> https://github.com/linux-can/can-utils
> 
> Is there a replacement for the canconfig utility from canutils?
> 
> Thanks,
> Clemens
> 


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] canutils problem on mainline kernel

[Clemens Gruber]

On Wed, Apr 13, 2016 at 03:52:34PM +0200, Marc Kleine-Budde wrote:
> No. What's the outout of:
> 
>     canconfig can0
> 

The output is:
no bittiming data found
can0: failed to get bitrate

> 
> There was a problem with the CAN clock on some imx in the kernel recently.

Hmm. in /sys/kernel/debug/clk/clk_summary, I see enable_cnt is 0 for
all can clocks.

Thank you Mark! With your hints, I found this bugfix on LKML:
https://lkml.org/lkml/2016/3/30/299
^ A very subtle typo!

Thanks,
Clemens

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] canutils problem on mainline kernel

[Marc Kleine-Budde]

[-- Attachment #1.1.1: Type: text/plain, Size: 898 bytes --]

On 04/13/2016 04:16 PM, Clemens Gruber wrote:
> On Wed, Apr 13, 2016 at 03:52:34PM +0200, Marc Kleine-Budde wrote:
>> No. What's the outout of:
>>
>>     canconfig can0
>>
> 
> The output is:
> no bittiming data found
> can0: failed to get bitrate
> 
>>
>> There was a problem with the CAN clock on some imx in the kernel recently.
> 
> Hmm. in /sys/kernel/debug/clk/clk_summary, I see enable_cnt is 0 for
> all can clocks.
> 
> Thank you Mark! With your hints, I found this bugfix on LKML:
> https://lkml.org/lkml/2016/3/30/299
> ^ A very subtle typo!
              V
ACK - It's Marc :D

regards

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] canutils problem on mainline kernel

[Clemens Gruber]

On Wed, Apr 13, 2016 at 04:17:40PM +0200, Marc Kleine-Budde wrote:
> ACK - It's Marc :D

Thanks, Marc ;)

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de