mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Robert Schwebel <r.schwebel@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] gptp: add new package for IEEE1588
Date: Tue, 16 Feb 2016 20:15:35 +0100	[thread overview]
Message-ID: <20160216191535.GK5923@pengutronix.de> (raw)
In-Reply-To: <20160216151628.GD4647@pengutronix.de>

On Tue, Feb 16, 2016 at 04:16:28PM +0100, Michael Olbrich wrote:
> On Tue, Feb 16, 2016 at 12:54:33PM +0100, Robert Schwebel wrote:
> > On Tue, Feb 16, 2016 at 12:30:35PM +0100, Michael Olbrich wrote:
> > > > +# ----------------------------------------------------------------------------
> > > > +# Prepare
> > > > +# ----------------------------------------------------------------------------
> > > > +
> > > > +LINUXPTP_CONF_TOOL	:= NO
> > > > +LINUXPTP_MAKE_OPT	:= $(CROSS_ENV_PROGS)
> > > 
> > > LINUXPTP_MAKE_OPT	:= \
> > > 	$(CROSS_ENV_PROGS)
> > > 	prefix=/usr
> > 
> > The makefile declares prefix with "=" and thus overwrites this, so it
> > doesn't have an effect.
> 
> Wrong. Variables set via make arguments (and not environment variables)
> overwrite variables set in the makefile.

True, I found the reason why it was ignored. In fact, it wasn't, but we
also have to set the variable manually on 'make install', not only on
'make'.
 
> > > > +# ----------------------------------------------------------------------------
> > > > +# Target-Install
> > > > +# ----------------------------------------------------------------------------
> > > > +
> > > > +$(STATEDIR)/linuxptp.targetinstall:
> > > > +	@$(call targetinfo)
> > > > +
> > > > +	@$(call install_init, linuxptp)
> > > > +	@$(call install_fixup, linuxptp,PRIORITY,optional)
> > > > +	@$(call install_fixup, linuxptp,SECTION,base)
> > > > +	@$(call install_fixup, linuxptp,AUTHOR,"Steffen Trumtrar <s.trumtrar@pengutronix.de>")
> > > > +	@$(call install_fixup, linuxptp,DESCRIPTION,missing)
> > > > +
> > > > +	@$(call install_copy, linuxptp, 0, 0, 0755, $(LINUXPTP_DIR)/ptp4l, /sbin/ptp4l)
> > > 
> > > 	@$(call install_copy, linuxptp, 0, 0, 0755, -, /sbin/ptp4l)
> > > 
> > > for all. Unless there is a reason for prefix=/ ?
> > 
> > The issue above results in the files being installed into /usr/local/*
> > anyway, which is the reason why the paths are set explicitly here.
> > 
> > Shall I patch the makefile to accept prefix=?
> > 
> > What do you think is the best place for the binaries: /sbin or
> > /usr/sbin?
> 
> I prefer /usr/sbin/.

Thanks, I've sent a v2.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2016-02-16 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 22:39 Robert Schwebel
2016-02-16 11:30 ` Michael Olbrich
2016-02-16 11:54   ` Robert Schwebel
2016-02-16 15:16     ` Michael Olbrich
2016-02-16 19:15       ` Robert Schwebel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160216191535.GK5923@pengutronix.de \
    --to=r.schwebel@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox