Re: [ptxdist] [PATH] usb-modeswitch-data: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Feb 03, 2016 at 11:10:15PM +0100, Ladislav Michl wrote:
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
> Notes:
>  - needs tcl on host, but... anyone seen note in rules/tcl.in?

Indeed. We have a mechanism for that now: Take a look at the host-system-*
packages. We should probably introduce a host-system-tcl for this, so it
fails early with a nice error message.

>  - colons in filenames, something to be solved...

Correct. I cannot apply this until that problem is solved, but I can still
review.

>  usb-modeswitch-data.in   |   10 ++++++
>  usb-modeswitch-data.make |   70 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 80 insertions(+)
> 
> diff --git a/rules/usb-modeswitch-data.in b/rules/usb-modeswitch-data.in
> new file mode 100644
> index 0000000..ffaacda
> --- /dev/null
> +++ b/rules/usb-modeswitch-data.in
> @@ -0,0 +1,10 @@
> +## SECTION=shell_and_console
> +
> +config USB_MODESWITCH_DATA
> +	tristate
> +	prompt "usb-modeswitch-data"
> +	depends on USB_MODESWITCH && UDEV

use select here to generate proper dependencies. If there is no buildtime
dependency, then use

	select <SOMETHING>	if RUNTIME

> +	help
> +	  Device database and udev rules file for USB_ModeSwitch.
> +
> +# vim: set sw=8 ts=8 noet ft=kconfig:
> diff --git a/rules/usb-modeswitch-data.make b/rules/usb-modeswitch-data.make
> new file mode 100644
> index 0000000..6b12898
> --- /dev/null
> +++ b/rules/usb-modeswitch-data.make
> @@ -0,0 +1,70 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2016 by Ladislav Michl <ladis@linux-mips.org>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_USB_MODESWITCH_DATA) += usb-modeswitch-data
> +
> +#
> +# Paths and names
> +#
> +USB_MODESWITCH_DATA_VERSION	:= 20160112
> +USB_MODESWITCH_DATA_MD5		:= 040d11138fc0a61b980d704ac3b4547f
> +USB_MODESWITCH_DATA		:= usb-modeswitch-data-$(USB_MODESWITCH_DATA_VERSION)
> +USB_MODESWITCH_DATA_SUFFIX	:= tar.bz2
> +USB_MODESWITCH_DATA_URL		:= http://www.draisberghof.de/usb_modeswitch/$(USB_MODESWITCH_DATA).$(USB_MODESWITCH_DATA_SUFFIX)
> +USB_MODESWITCH_DATA_SOURCE	:= $(SRCDIR)/$(USB_MODESWITCH_DATA).$(USB_MODESWITCH_DATA_SUFFIX)
> +USB_MODESWITCH_DATA_DIR		:= $(BUILDDIR)/$(USB_MODESWITCH_DATA)
> +USB_MODESWITCH_DATA_LICENSE	:= GPL-2.0
> +
> +
> +# ----------------------------------------------------------------------------
> +# Nothing to Compile

Just 'Compile' and move the stage after the prepare stuff.
Btw, what happens if just 'make' is called? Maybe there is some harmless
make target, that can be used.

> +# ----------------------------------------------------------------------------
> +$(STATEDIR)/usb-modeswitch-data.compile:
> +	@$(call targetinfo)
> +	@$(call touch)
> +
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +USB_MODESWITCH_DATA_CONF_TOOL	:= NO
> +USB_MODESWITCH_DATA_MAKE_ENV	:= $(CROSS_ENV)

use _INSTALL_ENV

> +USB_MODESWITCH_DATA_INSTALL_OPT	:= db-install
> +
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +$(STATEDIR)/usb-modeswitch-data.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, usb-modeswitch-data)
> +	@$(call install_fixup, usb-modeswitch-data,PRIORITY,optional)
> +	@$(call install_fixup, usb-modeswitch-data,SECTION,base)
> +	@$(call install_fixup, usb-modeswitch-data,AUTHOR,"Ladislav Michl <ladis@linux-mips.org>")
> +	@$(call install_fixup, usb-modeswitch-data,DESCRIPTION,missing)
> +
> +	@$(call install_copy, usb-modeswitch-data, 0, 0, 0644, -, \
> +		 /lib/udev/rules.d/40-usb_modeswitch.rules)
> +
> +	@cd $(USB_MODESWITCH_DATA_PKGDIR) && \
> +	for f in `find usr/share/usb_modeswitch/ -type f`; do \
> +		$(call install_copy, usb-modeswitch-data, 0, 0, 0644, -, /$$f); \
> +	done

install_tree should work here, right?

Michael

> +
> +	@$(call install_finish, usb-modeswitch-data)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de