mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] Busybox: fixed inverted BUSYBOX_DESKTOP for ps
@ 2016-01-22  9:37 Bruno Thomsen
  2016-01-22 15:13 ` Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Bruno Thomsen @ 2016-01-22  9:37 UTC (permalink / raw)
  To: ptxdist; +Cc: laa, bth

Currently you have to choose between -o options and -l/-w options.

This patch make it possible to enable all advanced ps features
when the BUSYBOX_DESKTOP flag is enabled.

Signed-off-by: Bruno Thomsen <bth@kamstrup.com>
---
 config/busybox/procps/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/busybox/procps/Config.in b/config/busybox/procps/Config.in
index 56b9150..a8f9e13 100644
--- a/config/busybox/procps/Config.in
+++ b/config/busybox/procps/Config.in
@@ -205,7 +205,7 @@ config BUSYBOX_PS
 config BUSYBOX_FEATURE_PS_WIDE
 	bool "Enable wide output option (-w)"
 	default y
-	depends on BUSYBOX_PS && !BUSYBOX_DESKTOP
+	depends on BUSYBOX_PS && BUSYBOX_DESKTOP
 	help
 	  Support argument 'w' for wide output.
 	  If given once, 132 chars are printed, and if given more
@@ -214,7 +214,7 @@ config BUSYBOX_FEATURE_PS_WIDE
 config BUSYBOX_FEATURE_PS_LONG
 	bool "Enable long output option (-l)"
 	default y
-	depends on BUSYBOX_PS && !BUSYBOX_DESKTOP
+	depends on BUSYBOX_PS && BUSYBOX_DESKTOP
 	help
 	  Support argument 'l' for long output.
 	  Adds fields PPID, RSS, START, TIME & TTY
-- 
2.1.4


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [PATCH] Busybox: fixed inverted BUSYBOX_DESKTOP for ps
  2016-01-22  9:37 [ptxdist] [PATCH] Busybox: fixed inverted BUSYBOX_DESKTOP for ps Bruno Thomsen
@ 2016-01-22 15:13 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2016-01-22 15:13 UTC (permalink / raw)
  To: ptxdist

On Fri, Jan 22, 2016 at 10:37:40AM +0100, Bruno Thomsen wrote:
> Currently you have to choose between -o options and -l/-w options.
> 
> This patch make it possible to enable all advanced ps features
> when the BUSYBOX_DESKTOP flag is enabled.

I don't think this works like this. The busybox build-system runs oldconfig
at some point. So we need a patch for busybox as well, right?

Michael

> Signed-off-by: Bruno Thomsen <bth@kamstrup.com>
> ---
>  config/busybox/procps/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/config/busybox/procps/Config.in b/config/busybox/procps/Config.in
> index 56b9150..a8f9e13 100644
> --- a/config/busybox/procps/Config.in
> +++ b/config/busybox/procps/Config.in
> @@ -205,7 +205,7 @@ config BUSYBOX_PS
>  config BUSYBOX_FEATURE_PS_WIDE
>  	bool "Enable wide output option (-w)"
>  	default y
> -	depends on BUSYBOX_PS && !BUSYBOX_DESKTOP
> +	depends on BUSYBOX_PS && BUSYBOX_DESKTOP
>  	help
>  	  Support argument 'w' for wide output.
>  	  If given once, 132 chars are printed, and if given more
> @@ -214,7 +214,7 @@ config BUSYBOX_FEATURE_PS_WIDE
>  config BUSYBOX_FEATURE_PS_LONG
>  	bool "Enable long output option (-l)"
>  	default y
> -	depends on BUSYBOX_PS && !BUSYBOX_DESKTOP
> +	depends on BUSYBOX_PS && BUSYBOX_DESKTOP
>  	help
>  	  Support argument 'l' for long output.
>  	  Adds fields PPID, RSS, START, TIME & TTY
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-22 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-22  9:37 [ptxdist] [PATCH] Busybox: fixed inverted BUSYBOX_DESKTOP for ps Bruno Thomsen
2016-01-22 15:13 ` Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox