Re: [ptxdist] Check for specific libc version

[Ladislav Michl <ladis@linux-mips.org>]

On Mon, Sep 28, 2015 at 12:29:02PM +0200, Michael Olbrich wrote:
> On Tue, Aug 18, 2015 at 12:30:41PM +0200, Ladislav Michl wrote:
[...]
> > This problem has side effect: as it seems the only variable used from
> > Versions.make is PTXDIST_FULLVERSION composed from PTXDIST_VERSION_FULL and
> > PTXCONF_PROJECT_VERSION where PTXCONF_PROJECT_VERSION is dumped anyway,
> > what about:
> 
> Be careful with making such statements. We have many cases where variables
> names are generated like this:
> 
> base		:=GCC
> version_var	:=$(base)_VERSION
> major		:=$($(version_var)_MAJOR)
> 
> This example is completely fabricated, but I think you can see how just
> searching for the variable names is not enough.
> 
> In this case, I think the variables aren't used, but I'll need to review
> the code carefully before applying such a patch.

Gentle ping... I'm still holding this patch in my tree and built quite few
projects with it. So, here it is again for your consideration

From: Ladislav Michl <ladis@linux-mips.org>
Date: Tue, 18 Aug 2015 12:18:13 +0200
Subject: [PATCH] Remove unused Version.make

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 rules/post/dump.make   |  2 +-
 rules/pre/Version.make | 27 ---------------------------
 2 files changed, 1 insertion(+), 28 deletions(-)
 delete mode 100644 rules/pre/Version.make

diff --git a/rules/post/dump.make b/rules/post/dump.make
index 9931ee4..bba46d7 100644
--- a/rules/post/dump.make
+++ b/rules/post/dump.make
@@ -26,7 +26,7 @@ M2B_DUMP_VARIABLES := \
 	PTXCONF_CONFIGFILE_VERSION \
 	PTXCONFIG PTXCONF_SYSROOT_TARGET PTXCONF_PROJECT PTXCONF_PROJECT_VERSION \
 	PTXDIST_WORKSPACE PTXDIST_TOPDIR \
-	PTXDIST PTXDIST_FULLVERSION \
+	PTXDIST PTXDIST_VERSION_FULL \
 	RULESDIR SCRIPTSDIR STATEDIR SYSROOT WORKDIR \
 	PACKAGES- PACKAGES-y PACKAGES-m
 
diff --git a/rules/pre/Version.make b/rules/pre/Version.make
deleted file mode 100644
index 5ebc827..0000000
--- a/rules/pre/Version.make
+++ /dev/null
@@ -1,27 +0,0 @@
-# -*-makefile-*-
-#
-# Copyright (C) 2003 by Marc Kleine-Budde <kleine-budde@gmx.de>
-#           (C) 2008 by Wolfram Sang <w.sang@pengutronix.de>
-#
-# See CREDITS for details about who has contributed to this project.
-#
-# For further information about the PTXdist project and license conditions
-# see the README file.
-#
-
-GCC_VERSION		:= $(call remove_quotes,$(PTXCONF_CROSSCHAIN_CHECK))
-_version_temp		:= $(subst ., ,$(GCC_VERSION))
-GCC_VERSION_MAJOR	:= $(word 1,$(_version_temp))
-GCC_VERSION_MINOR	:= $(word 2,$(_version_temp))
-GCC_VERSION_MICRO	:= $(word 3,$(_version_temp))
-
-GLIBC_VERSION		:= $(call remove_quotes,$(PTXCONF_GLIBC_VERSION))
-_version_temp		:= $(subst ., ,$(GLIBC_VERSION))
-GLIBC_VERSION_MAJOR	:= $(word 1,$(_version_temp))
-GLIBC_VERSION_MINOR	:= $(word 2,$(_version_temp))
-GLIBC_VERSION_MICRO	:= $(word 3,$(_version_temp))
-
-PTXDIST_FULLVERSION	:= $(call remove_quotes,ptxdist-$(PTXDIST_VERSION_FULL)$(PTXCONF_PROJECT_VERSION))
-_version_temp		:=
-
-# vim: syntax=make
-- 
2.1.4


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de