* [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
@ 2015-11-30 14:09 Kalle Ladefoged Pedersen
2015-11-30 17:20 ` Ladislav Michl
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Ladefoged Pedersen @ 2015-11-30 14:09 UTC (permalink / raw)
To: ptxdist; +Cc: Kalle Ladefoged Pedersen
Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
---
rules/php5.in | 10 ++++++++++
rules/php5.make | 7 ++++++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/rules/php5.in b/rules/php5.in
index d2f7baa..b88ad1b 100644
--- a/rules/php5.in
+++ b/rules/php5.in
@@ -289,6 +289,16 @@ config PHP5_EXT_PEAR
help
pear
+config PHP5_EXT_PHAR
+ bool
+ prompt "phar"
+ help
+ The phar extension provides a way to put entire PHP applications
+ into a single file called "phar" (PHP Archive) for easy
+ distribution and installation. The phar extension also provides
+ a file-format abstraction method for creating and manipulating
+ tar and zip files through the PharData class.
+
endmenu
endif
diff --git a/rules/php5.make b/rules/php5.make
index 98fc788..f98d37e 100644
--- a/rules/php5.make
+++ b/rules/php5.make
@@ -48,7 +48,6 @@ PHP5_CONF_ENV := \
#
PHP5_AUTOCONF := \
$(CROSS_AUTOCONF_USR) \
- --disable-phar \
--with-config-file-path=/etc/php5 \
--enable-opcache=no \
--without-iconv
@@ -270,6 +269,12 @@ else
PHP5_AUTOCONF += --without-pear
endif
+ifdef PTXCONF_PHP5_EXT_PHAR
+PHP5_AUTOCONF += --enable-phar
+else
+PHP5_AUTOCONF += --disable-phar
+endif
+
# ----------------------------------------------------------------------------
# Target-Install
# ----------------------------------------------------------------------------
--
2.1.4
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
2015-11-30 14:09 [ptxdist] [PATCH] Enable support for the phar extension in PHP5 Kalle Ladefoged Pedersen
@ 2015-11-30 17:20 ` Ladislav Michl
2015-12-17 10:45 ` Michael Olbrich
0 siblings, 1 reply; 7+ messages in thread
From: Ladislav Michl @ 2015-11-30 17:20 UTC (permalink / raw)
To: ptxdist; +Cc: Kalle Ladefoged Pedersen
On Mon, Nov 30, 2015 at 03:09:21PM +0100, Kalle Ladefoged Pedersen wrote:
> Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
> Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
> ---
> rules/php5.in | 10 ++++++++++
> rules/php5.make | 7 ++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/rules/php5.in b/rules/php5.in
> index d2f7baa..b88ad1b 100644
> --- a/rules/php5.in
> +++ b/rules/php5.in
[snip]
> +ifdef PTXCONF_PHP5_EXT_PHAR
> +PHP5_AUTOCONF += --enable-phar
> +else
> +PHP5_AUTOCONF += --disable-phar
> +endif
> +
Wouldn't '--$(call ptx/endis, PTXCONF_PHP5_EXT_PHAR)-phar' do better job?
regards,
ladis
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
2015-11-30 17:20 ` Ladislav Michl
@ 2015-12-17 10:45 ` Michael Olbrich
2015-12-17 11:10 ` Michael Olbrich
0 siblings, 1 reply; 7+ messages in thread
From: Michael Olbrich @ 2015-12-17 10:45 UTC (permalink / raw)
To: ptxdist
On Mon, Nov 30, 2015 at 06:20:22PM +0100, Ladislav Michl wrote:
> On Mon, Nov 30, 2015 at 03:09:21PM +0100, Kalle Ladefoged Pedersen wrote:
> > Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
> > Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
> > ---
> > rules/php5.in | 10 ++++++++++
> > rules/php5.make | 7 ++++++-
> > 2 files changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/rules/php5.in b/rules/php5.in
> > index d2f7baa..b88ad1b 100644
> > --- a/rules/php5.in
> > +++ b/rules/php5.in
> [snip]
> > +ifdef PTXCONF_PHP5_EXT_PHAR
> > +PHP5_AUTOCONF += --enable-phar
> > +else
> > +PHP5_AUTOCONF += --disable-phar
> > +endif
> > +
>
> Wouldn't '--$(call ptx/endis, PTXCONF_PHP5_EXT_PHAR)-phar' do better job?
The other options are specified like this as well. So at least it's
consistent. The whole file should be cleaned up. But that needs careful
testing because not all options accept --without-... (or at least they
didn't. ptx/ifdef needs to be used in that case...
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
2015-12-17 10:45 ` Michael Olbrich
@ 2015-12-17 11:10 ` Michael Olbrich
2016-01-14 8:03 ` Kalle Ladefoged Pedersen
0 siblings, 1 reply; 7+ messages in thread
From: Michael Olbrich @ 2015-12-17 11:10 UTC (permalink / raw)
To: ptxdist
On Thu, Dec 17, 2015 at 11:45:09AM +0100, Michael Olbrich wrote:
> On Mon, Nov 30, 2015 at 06:20:22PM +0100, Ladislav Michl wrote:
> > On Mon, Nov 30, 2015 at 03:09:21PM +0100, Kalle Ladefoged Pedersen wrote:
> > > Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
> > > Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
> > > ---
> > > rules/php5.in | 10 ++++++++++
> > > rules/php5.make | 7 ++++++-
> > > 2 files changed, 16 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/rules/php5.in b/rules/php5.in
> > > index d2f7baa..b88ad1b 100644
> > > --- a/rules/php5.in
> > > +++ b/rules/php5.in
> > [snip]
> > > +ifdef PTXCONF_PHP5_EXT_PHAR
> > > +PHP5_AUTOCONF += --enable-phar
> > > +else
> > > +PHP5_AUTOCONF += --disable-phar
> > > +endif
> > > +
> >
> > Wouldn't '--$(call ptx/endis, PTXCONF_PHP5_EXT_PHAR)-phar' do better job?
>
> The other options are specified like this as well. So at least it's
> consistent. The whole file should be cleaned up. But that needs careful
> testing because not all options accept --without-... (or at least they
> didn't. ptx/ifdef needs to be used in that case...
and it fails with:
[...]
Generating phar.php
[...]/build-target/php-5.5.30/sapi/cli/php: Argument list too long
Which is bogus because [...]/build-target/php-5.5.30/sapi/cli/php is a
target binary. There is a cross-compiling problem here.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
2015-12-17 11:10 ` Michael Olbrich
@ 2016-01-14 8:03 ` Kalle Ladefoged Pedersen
2016-01-18 9:26 ` Michael Olbrich
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Ladefoged Pedersen @ 2016-01-14 8:03 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 2734 bytes --]
Hi Michael,
It works fine with our build setup for an Freescale i.MX28 processor with PHP 5.5.30 and lighttpd 1.4.39
We use OSELAS.Toolchain-2014.12.1 (arm-v5te-linux-gnueabi/gcc-4.9.2-glibc-2.20-binutils-2.24-kernel-3.16-sanitized) and ptxdist-2015.10.0 for compiling.
We tried to see if we could reproduce the error that you got but we didn’t succeed.
Can you please let me know what setup you are running?
Venlig hilsen / Best regards
Kamstrup A/S
Kalle Ladefoged Pedersen
Student programmer
Technology
Kamstrup A/S
Industrivej 28
DK-8660 Skanderborg
T: +45 89 93 10 00
D: +45 89 93 16 18
klp@kamstrup.com
kamstrup.com
-----Original Message-----
From: ptxdist [mailto:ptxdist-bounces@pengutronix.de] On Behalf Of Michael Olbrich
Sent: 17. december 2015 12:11
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
On Thu, Dec 17, 2015 at 11:45:09AM +0100, Michael Olbrich wrote:
> On Mon, Nov 30, 2015 at 06:20:22PM +0100, Ladislav Michl wrote:
> > On Mon, Nov 30, 2015 at 03:09:21PM +0100, Kalle Ladefoged Pedersen wrote:
> > > Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
> > > Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
> > > ---
> > > rules/php5.in | 10 ++++++++++
> > > rules/php5.make | 7 ++++++-
> > > 2 files changed, 16 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/rules/php5.in b/rules/php5.in index d2f7baa..b88ad1b
> > > 100644
> > > --- a/rules/php5.in
> > > +++ b/rules/php5.in
> > [snip]
> > > +ifdef PTXCONF_PHP5_EXT_PHAR
> > > +PHP5_AUTOCONF += --enable-phar
> > > +else
> > > +PHP5_AUTOCONF += --disable-phar
> > > +endif
> > > +
> >
> > Wouldn't '--$(call ptx/endis, PTXCONF_PHP5_EXT_PHAR)-phar' do better job?
>
> The other options are specified like this as well. So at least it's
> consistent. The whole file should be cleaned up. But that needs
> careful testing because not all options accept --without-... (or at
> least they didn't. ptx/ifdef needs to be used in that case...
and it fails with:
[...]
Generating phar.php
[...]/build-target/php-5.5.30/sapi/cli/php: Argument list too long
Which is bogus because [...]/build-target/php-5.5.30/sapi/cli/php is a target binary. There is a cross-compiling problem here.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3551 bytes --]
[-- Attachment #2: Type: text/plain, Size: 91 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
2016-01-14 8:03 ` Kalle Ladefoged Pedersen
@ 2016-01-18 9:26 ` Michael Olbrich
2016-01-19 12:08 ` Pallavi Kadadi
0 siblings, 1 reply; 7+ messages in thread
From: Michael Olbrich @ 2016-01-18 9:26 UTC (permalink / raw)
To: ptxdist
Hi,
On Thu, Jan 14, 2016 at 08:03:47AM +0000, Kalle Ladefoged Pedersen wrote:
> It works fine with our build setup for an Freescale i.MX28 processor with PHP 5.5.30 and lighttpd 1.4.39
> We use OSELAS.Toolchain-2014.12.1
> (arm-v5te-linux-gnueabi/gcc-4.9.2-glibc-2.20-binutils-2.24-kernel-3.16-sanitized)
> and ptxdist-2015.10.0 for compiling.
>
> We tried to see if we could reproduce the error that you got but we didn’t succeed.
> Can you please let me know what setup you are running?
I don't have the exact config here right now, but it was my 'build
everything' BSP so I guess all PHP5 options enables and
PTXCONF_PHP5_SAPI_APXS2=y for the choice.
Regards,
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
2016-01-18 9:26 ` Michael Olbrich
@ 2016-01-19 12:08 ` Pallavi Kadadi
0 siblings, 0 replies; 7+ messages in thread
From: Pallavi Kadadi @ 2016-01-19 12:08 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]
Please unsubscibe me from this list
On Mon, Jan 18, 2016 at 2:56 PM, Michael Olbrich <m.olbrich@pengutronix.de>
wrote:
> Hi,
>
> On Thu, Jan 14, 2016 at 08:03:47AM +0000, Kalle Ladefoged Pedersen wrote:
> > It works fine with our build setup for an Freescale i.MX28 processor
> with PHP 5.5.30 and lighttpd 1.4.39
> > We use OSELAS.Toolchain-2014.12.1
> >
> (arm-v5te-linux-gnueabi/gcc-4.9.2-glibc-2.20-binutils-2.24-kernel-3.16-sanitized)
> > and ptxdist-2015.10.0 for compiling.
> >
> > We tried to see if we could reproduce the error that you got but we
> didn’t succeed.
> > Can you please let me know what setup you are running?
>
> I don't have the exact config here right now, but it was my 'build
> everything' BSP so I guess all PHP5 options enables and
> PTXCONF_PHP5_SAPI_APXS2=y for the choice.
>
> Regards,
> Michael
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
>
[-- Attachment #1.2: Type: text/html, Size: 1892 bytes --]
[-- Attachment #2: Type: text/plain, Size: 91 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-19 12:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-30 14:09 [ptxdist] [PATCH] Enable support for the phar extension in PHP5 Kalle Ladefoged Pedersen
2015-11-30 17:20 ` Ladislav Michl
2015-12-17 10:45 ` Michael Olbrich
2015-12-17 11:10 ` Michael Olbrich
2016-01-14 8:03 ` Kalle Ladefoged Pedersen
2016-01-18 9:26 ` Michael Olbrich
2016-01-19 12:08 ` Pallavi Kadadi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox