Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Dec 17, 2015 at 11:45:09AM +0100, Michael Olbrich wrote:
> On Mon, Nov 30, 2015 at 06:20:22PM +0100, Ladislav Michl wrote:
> > On Mon, Nov 30, 2015 at 03:09:21PM +0100, Kalle Ladefoged Pedersen wrote:
> > > Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
> > > Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
> > > ---
> > >  rules/php5.in   | 10 ++++++++++
> > >  rules/php5.make |  7 ++++++-
> > >  2 files changed, 16 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/rules/php5.in b/rules/php5.in
> > > index d2f7baa..b88ad1b 100644
> > > --- a/rules/php5.in
> > > +++ b/rules/php5.in
> > [snip]
> > > +ifdef PTXCONF_PHP5_EXT_PHAR
> > > +PHP5_AUTOCONF += --enable-phar
> > > +else
> > > +PHP5_AUTOCONF += --disable-phar
> > > +endif
> > > +
> > 
> > Wouldn't '--$(call ptx/endis, PTXCONF_PHP5_EXT_PHAR)-phar' do better job?
> 
> The other options are specified like this as well. So at least it's
> consistent. The whole file should be cleaned up. But that needs careful
> testing because not all options accept --without-... (or at least they
> didn't. ptx/ifdef needs to be used in that case...

and it fails with:

[...]
Generating phar.php
[...]/build-target/php-5.5.30/sapi/cli/php: Argument list too long

Which is bogus because [...]/build-target/php-5.5.30/sapi/cli/php is a
target binary. There is a cross-compiling problem here.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de