Re: [ptxdist] [PATCH] maildrop: this patch adds maildrop to ptxdist

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Oct 22, 2015 at 04:09:14PM +0200, Oliver Graute wrote:
> maildrop is a mail delivery agent with filtering abilities
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/maildrop.in   |    8 ++++
>  rules/maildrop.make |  106 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 114 insertions(+)
>  create mode 100644 rules/maildrop.in
>  create mode 100644 rules/maildrop.make
> 
> diff --git a/rules/maildrop.in b/rules/maildrop.in
> new file mode 100644
> index 0000000..f2b4660
> --- /dev/null
> +++ b/rules/maildrop.in
> @@ -0,0 +1,8 @@
> +## SECTION=communication
> +
> +menuconfig MAILDROP
> +	depends on COURIER_UNICODE


This must be "select COURIER_UNICODE". Otherwise the dependencies won't
work correctly.

> +	tristate
> +	prompt "maildrop"
> +	help
> +	  maildrop - mail delivery agent with filtering abilities
> diff --git a/rules/maildrop.make b/rules/maildrop.make
> new file mode 100644
> index 0000000..36707a0
> --- /dev/null
> +++ b/rules/maildrop.make
> @@ -0,0 +1,106 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MAILDROP) += maildrop
> +
> +#
> +# Paths and names
> +#
> +MAILDROP_VERSION	:= 2.8.3
> +MAILDROP_MD5		:= 4e3b2b19b58a76581a486381e4444b5e
> +MAILDROP		:= maildrop-$(MAILDROP_VERSION)
> +MAILDROP_SUFFIX	:= tar.bz2
> +MAILDROP_URL		:= http://downloads.sourceforge.net/project/courier/maildrop/$(MAILDROP_VERSION)/$(MAILDROP).$(MAILDROP_SUFFIX)
> +MAILDROP_SOURCE	:= $(SRCDIR)/$(MAILDROP).$(MAILDROP_SUFFIX)
> +MAILDROP_DIR		:= $(BUILDDIR)/$(MAILDROP)
> +MAILDROP_LICENSE	:= GPLv3
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +MAILDROP_CONF_ENV	:= $(CROSS_ENV)
> +
> +AUTOCONFIG_POSTFIX_EXTRAS+=\
> +	ac_cv_func_getpgrp_void=yes \
> +	ac_cv_func_setpgrp_void=yes \
> +	ac_cv_func_memcmp_working=yes \
> +	rb_cv_binary_elf=no \
> +	rb_cv_negative_time_t=no

this should be part of MAILDROP_CONF_ENV

> +#
> +# autoconf
> +#
> +MAILDROP_CONF_TOOL	:= autoconf
> +MAILDROP_CONF_OPT	:= $(CROSS_AUTOCONF_USR)\
> +			--with-locking-method=fcntl

Break like this:

MAILDROP_CONF_OPT	:= \
	$(CROSS_AUTOCONF_USR) \
	...

Also:

--without-db or it will try to autodetect
And I think --disable-tempdir would make sense.

I've said this before: You need to specify more configure options:
As a general rule all options that match the following criteria _must_ be
specified:
- ipv6 and largefile options
- any options that handles a external package dependency. Auto detection is
  never acceptable.
- any option that enables/disables sub-components
- any option for paths/binaries that are needed at runtime


> +#CPPFLAGS="-L/$(PTXDIST_SYSROOT_TARGET)/lib -I $(PTXDIST_SYSROOT_TARGET)/usr/include"

remove

> +$(STATEDIR)/maildrop.prepare:
> +	@$(call targetinfo)
> +	@$(call clean, $(MAILDROP_DIR)/config.cache)
> +	cd $(MAILDROP_DIR) && \
> +		$(MAILDROP_PATH) $(MAILDROP_ENV) \
> +		$(AUTOCONFIG_POSTFIX_EXTRAS) ./configure $(MAILDROP_CONF_OPT)
> +	@$(call touch)

remove

> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/maildrop.compile:
> +	@$(call targetinfo)
> +	@$(call world/compile, MAILDROP)
> +	@$(call touch)
> +

remove

> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/maildrop.install:
> +	@$(call targetinfo)
> +	@$(call world/install, MAILDROP)
> +	@$(call touch)
> +

remove

> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/maildrop.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, maildrop)
> +	@$(call install_fixup, maildrop,PRIORITY,optional)
> +	@$(call install_fixup, maildrop,SECTION,base)
> +	@$(call install_fixup, maildrop,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, maildrop,DESCRIPTION,missing)
> +
> +	@$(call install_copy, maildrop, 0, 0, 0755, $(MAILDROP_DIR)/libs/maildrop/maildrop, /usr/bin/maildrop)
> +	@$(call install_copy, maildrop, 0, 0, 0755, $(MAILDROP_DIR)/libs/maildrop/mailbot, /usr/bin/mailbot)
> +	@$(call install_copy, maildrop, 0, 0, 0755, $(MAILDROP_DIR)/libs/maildrop/reformail, /usr/bin/reformail)
> +	@$(call install_copy, maildrop, 0, 0, 0755, $(MAILDROP_DIR)/libs/rfc2045/makemime, /usr/bin/makemime)
> +	@$(call install_copy, maildrop, 0, 0, 0755, $(MAILDROP_DIR)/libs/rfc2045/reformime, /usr/bin/reformime)

What happens in the install stage? Usually '-' is enough as source path.

> +
> +	@$(call install_finish, maildrop)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Clean
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/maildrop.clean:
> +	@$(call targetinfo)
> +	@$(call clean_pkg, MAILDROP)

remove

Michael

> +
> +# vim: syntax=make
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de