mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Cc: Kalle Ladefoged Pedersen <klp@kamstrup.com>
Subject: Re: [ptxdist] [PATCH] Enable support for the phar extension in PHP5.
Date: Mon, 30 Nov 2015 18:20:22 +0100	[thread overview]
Message-ID: <20151130172022.GA1647@localhost.localdomain> (raw)
In-Reply-To: <1448892561-20400-1-git-send-email-klp@kamstrup.com>

On Mon, Nov 30, 2015 at 03:09:21PM +0100, Kalle Ladefoged Pedersen wrote:
> Signed-off-by: Kalle Ladefoged Pedersen <klp@kamstrup.com>
> Reviewed-by: Bruno Thomsen <bth@kamstrup.com>
> ---
>  rules/php5.in   | 10 ++++++++++
>  rules/php5.make |  7 ++++++-
>  2 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/php5.in b/rules/php5.in
> index d2f7baa..b88ad1b 100644
> --- a/rules/php5.in
> +++ b/rules/php5.in
[snip]
> +ifdef PTXCONF_PHP5_EXT_PHAR
> +PHP5_AUTOCONF += --enable-phar
> +else
> +PHP5_AUTOCONF += --disable-phar
> +endif
> +

Wouldn't '--$(call ptx/endis, PTXCONF_PHP5_EXT_PHAR)-phar' do better job?

regards,
	ladis

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2015-11-30 17:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 14:09 Kalle Ladefoged Pedersen
2015-11-30 17:20 ` Ladislav Michl [this message]
2015-12-17 10:45   ` Michael Olbrich
2015-12-17 11:10     ` Michael Olbrich
2016-01-14  8:03       ` Kalle Ladefoged Pedersen
2016-01-18  9:26         ` Michael Olbrich
2016-01-19 12:08           ` Pallavi Kadadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130172022.GA1647@localhost.localdomain \
    --to=ladis@linux-mips.org \
    --cc=klp@kamstrup.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox