* [ptxdist] [PATCH] lldpd: bump version to 0.7.19 @ 2015-11-07 17:26 Clemens Gruber 2015-11-09 7:46 ` Alexander Dahl 0 siblings, 1 reply; 6+ messages in thread From: Clemens Gruber @ 2015-11-07 17:26 UTC (permalink / raw) To: ptxdist; +Cc: Clemens Gruber Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com> --- rules/lldpd.make | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/lldpd.make b/rules/lldpd.make index 37ba590..3c015bf 100644 --- a/rules/lldpd.make +++ b/rules/lldpd.make @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LLDPD) += lldpd # # Paths and names # -LLDPD_VERSION := 0.7.6 -LLDPD_MD5 := dbd90a68b91448dcb94a4a77c5d8ef65 +LLDPD_VERSION := 0.7.19 +LLDPD_MD5 := 4e924420e00ccd5dc289506f43221820 LLDPD := lldpd-$(LLDPD_VERSION) LLDPD_SUFFIX := tar.gz LLDPD_URL := http://media.luffy.cx/files/lldpd//$(LLDPD).$(LLDPD_SUFFIX) -- 2.6.2 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] lldpd: bump version to 0.7.19 2015-11-07 17:26 [ptxdist] [PATCH] lldpd: bump version to 0.7.19 Clemens Gruber @ 2015-11-09 7:46 ` Alexander Dahl 2015-11-09 9:58 ` Clemens Gruber 0 siblings, 1 reply; 6+ messages in thread From: Alexander Dahl @ 2015-11-09 7:46 UTC (permalink / raw) To: ptxdist [-- Attachment #1: Type: text/plain, Size: 1409 bytes --] Hei hei, Am 2015-11-07 18:26, schrieb Clemens Gruber: > -LLDPD_VERSION := 0.7.6 > -LLDPD_MD5 := dbd90a68b91448dcb94a4a77c5d8ef65 > +LLDPD_VERSION := 0.7.19 > +LLDPD_MD5 := 4e924420e00ccd5dc289506f43221820 I'm afraid it's not that simple. Some configure options changed and some where added. This should be adressed in rules/lldpd.make and maybe in rules/lldpd.in as well. I attach a diff of the output of ./configure --help to this mail. Another point is to check the new pid file handling. There's a new option --with-lldpd-pid-file in the configure output which should be checked against projectroot/etc/init.d/lldpd which is the startup script for bbinit. The new possibility to link against json-c should be checked. There seems to be some new support for systemd. The with-privsep options should also be checked, there were some upstream changes in lldpd 0.7.8. Maybe the https://github.com/vincentbernat/lldpd/blob/branch-0.7/NEWS could also be helpful. I would be happy if you could have a look into this, I'm also interested in an updated package, but didn't have time to investigate this further yet. ;-) Greets Alex -- »With the first link, the chain is forged. The first speech censured, the first thought forbidden, the first freedom denied, chains us all irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie) *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601 D1D5 8FBA 7744 CC87 10D0 *** [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: lldpd-configure-help-0.7.6-to-0.7.19.diff --] [-- Type: text/x-diff; name=lldpd-configure-help-0.7.6-to-0.7.19.diff, Size: 5343 bytes --] --- lldpd-configure-help-0.7.6 2015-11-09 08:26:29.167359732 +0100 +++ lldpd-configure-help-0.7.19 2015-11-09 08:27:17.287031222 +0100 @@ -1,4 +1,4 @@ -`configure' configures lldpd 0.7.6-dirty to adapt to many kinds of systems. +`configure' configures lldpd 0.7.19-dirty to adapt to many kinds of systems. Usage: ./configure [OPTION]... [VAR=VALUE]... @@ -79,6 +79,9 @@ --enable-fast-install[=PKGS] optimize for fast installation [default=yes] --disable-libtool-lock avoid locking (might break parallel builds) + --enable-ld-version-script + enable linker version script (default is enabled + when possible) --disable-doxygen-doc don't generate any doxygen documentation --enable-doxygen-dot generate graphics for doxygen documentation --enable-doxygen-man generate doxygen manual pages @@ -90,6 +93,10 @@ --disable-doxygen-html don't generate doxygen plain HTML documentation --enable-doxygen-ps generate doxygen PostScript documentation --disable-doxygen-pdf don't generate doxygen PDF documentation + --enable-hardening Enable compiler and linker options to frustrate + memory corruption exploits [default=yes] + --enable-dtrace Enable systemtap/DTrace trace support [default=no] + --enable-privsep Enable Privilege separation [default=yes] --enable-cdp Enable Cisco Discovery Protocol [default=yes] --enable-fdp Enable Foundry Discovery Protocol [default=yes] --enable-edp Enable Extreme Discovery Protocol [default=yes] @@ -98,8 +105,9 @@ --enable-lldpmed Enable LLDP-MED extension [default=yes] --enable-dot1 Enable Dot1 extension (VLAN stuff) [default=yes] --enable-dot3 Enable Dot3 extension (PHY stuff) [default=yes] + --enable-custom Enable Custom TLV support [default=yes] --enable-oldies Enable compatibility with Linux kernel older than - 2.6.18 [default=no] + 2.6.32 [default=no] Optional Packages: --with-PACKAGE[=ARG] use PACKAGE [ARG=yes] @@ -110,18 +118,37 @@ --with-sysroot=DIR Search for dependent libraries within DIR (or the compiler's sysroot if not specified). --with-embedded-libevent - Force the use of embedded libevent [default=no] + Use embedded libevent [default=auto] + --with-pkgconfigdir pkg-config installation directory + ['${libdir}/pkgconfig'] --with-readline Enable the use of readline-like library - [default=check] + [default=auto] --with-snmp Enable the use of SNMP [default=no] - --with-xml Enable XML output via libxml2 [default=no] - --with-json Enable JSON output via Jansson [default=no] + --with-xml Enable XML output via libxml2 [default=auto] + --with-json Enable JSON output via janson or json-c + [default=auto] + --with-seccomp Enable seccomp support (with libseccomp) + [default=no] + --with-launchddaemonsdir + Directory for launchd configuration file (OSX) + [default=/Library/LaunchDaemons] + --with-systemdsystemunitdir + Directory for systemd service files + [default=$($PKG_CONFIG + --variable=systemdsystemunitdir systemd 2> + /dev/null)] + --with-sysusersdir Directory for sysusers files [default=$($PKG_CONFIG + --variable=sysusersdir systemd 2> /dev/null)] --with-privsep-user Which user to use for privilege separation [default=_lldpd] --with-privsep-group Which group to use for privilege separation [default=_lldpd] --with-privsep-chroot Which directory to use to chroot lldpd - [default=/var/run/lldpd] + [default=${runstatedir}/lldpd] + --with-lldpd-ctl-socket Path to socket for communication with lldpd + [default=${runstatedir}/lldpd.socket] + --with-lldpd-pid-file Path to lldpd PID file + [default=${runstatedir}/lldpd.pid] Some influential environment variables: CC C compiler command @@ -155,8 +182,16 @@ C compiler flags for JANSSON, overriding pkg-config JANSSON_LIBS linker flags for JANSSON, overriding pkg-config + JSONC_CFLAGS + C compiler flags for JSONC, overriding pkg-config + JSONC_LIBS linker flags for JSONC, overriding pkg-config + SECCOMP_CFLAGS + C compiler flags for SECCOMP, overriding pkg-config + SECCOMP_LIBS + linker flags for SECCOMP, overriding pkg-config Use these variables to override the choices made by `configure' or to help it to find libraries and programs with nonstandard names/locations. -Report bugs to <bernat@luffy.cx>. +Report bugs to <https://github.com/vincentbernat/lldpd/issues>. +lldpd home page: <http://vincentbernat.github.io/lldpd/>. [-- Attachment #3: Type: text/plain, Size: 91 bytes --] _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] lldpd: bump version to 0.7.19 2015-11-09 7:46 ` Alexander Dahl @ 2015-11-09 9:58 ` Clemens Gruber 2015-11-16 13:11 ` Clemens Gruber 0 siblings, 1 reply; 6+ messages in thread From: Clemens Gruber @ 2015-11-09 9:58 UTC (permalink / raw) To: Alexander Dahl; +Cc: ptxdist Hi Alexander, On Mon, Nov 09, 2015 at 08:46:09AM +0100, Alexander Dahl wrote: > Hei hei, > > Am 2015-11-07 18:26, schrieb Clemens Gruber: > > -LLDPD_VERSION := 0.7.6 > > -LLDPD_MD5 := dbd90a68b91448dcb94a4a77c5d8ef65 > > +LLDPD_VERSION := 0.7.19 > > +LLDPD_MD5 := 4e924420e00ccd5dc289506f43221820 > > I'm afraid it's not that simple. Some configure options changed and some > where added. This should be adressed in rules/lldpd.make and maybe in > rules/lldpd.in as well. I attach a diff of the output of ./configure > --help to this mail. > > Another point is to check the new pid file handling. There's a new > option --with-lldpd-pid-file in the configure output which should be > checked against projectroot/etc/init.d/lldpd which is the startup script > for bbinit. This works out of the box. It uses /var/run/lldpd.pid by default. > > The new possibility to link against json-c should be checked. There > seems to be some new support for systemd. The with-privsep options > should also be checked, there were some upstream changes in lldpd 0.7.8. In v2, I added an option to enable the JSON output format (but only with json-c as we do not have Jansson in ptxdist) > > Maybe the https://github.com/vincentbernat/lldpd/blob/branch-0.7/NEWS > could also be helpful. Yes, I updated the minimum kernel version in the oldies option and added an option for custom TLVs. > > I would be happy if you could have a look into this, I'm also interested > in an updated package, but didn't have time to investigate this further > yet. ;-) Privilege separation options are OK. I did not enable seccomp because they do not use the syscall directly but through libseccomp which is not in ptxdist. Also, it is not yet enabled by default by the developer, so I think this can wait a little bit. lldpd works on my system with busybox init. I do not have a systemd box with ptxdist however. (It should detect the correct location via pkg-config, right?) Would be great if you could give the v2 patch a try, especially wrt systemd. > > Greets > Alex > > -- > »With the first link, the chain is forged. The first speech censured, > the first thought forbidden, the first freedom denied, chains us all > irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie) > *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601 D1D5 8FBA 7744 CC87 10D0 *** Thanks, Clemens _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] lldpd: bump version to 0.7.19 2015-11-09 9:58 ` Clemens Gruber @ 2015-11-16 13:11 ` Clemens Gruber 2015-11-16 13:26 ` Alexander Dahl 0 siblings, 1 reply; 6+ messages in thread From: Clemens Gruber @ 2015-11-16 13:11 UTC (permalink / raw) To: Alexander Dahl; +Cc: ptxdist On Mon, Nov 09, 2015 at 10:58:12AM +0100, Clemens Gruber wrote: > Hi Alexander, > > On Mon, Nov 09, 2015 at 08:46:09AM +0100, Alexander Dahl wrote: > > Hei hei, > > > > Am 2015-11-07 18:26, schrieb Clemens Gruber: > > > -LLDPD_VERSION := 0.7.6 > > > -LLDPD_MD5 := dbd90a68b91448dcb94a4a77c5d8ef65 > > > +LLDPD_VERSION := 0.7.19 > > > +LLDPD_MD5 := 4e924420e00ccd5dc289506f43221820 > > > > I'm afraid it's not that simple. Some configure options changed and some > > where added. This should be adressed in rules/lldpd.make and maybe in > > rules/lldpd.in as well. I attach a diff of the output of ./configure > > --help to this mail. > > > > Another point is to check the new pid file handling. There's a new > > option --with-lldpd-pid-file in the configure output which should be > > checked against projectroot/etc/init.d/lldpd which is the startup script > > for bbinit. > > This works out of the box. It uses /var/run/lldpd.pid by default. > > > > > The new possibility to link against json-c should be checked. There > > seems to be some new support for systemd. The with-privsep options > > should also be checked, there were some upstream changes in lldpd 0.7.8. > > In v2, I added an option to enable the JSON output format (but only with json-c > as we do not have Jansson in ptxdist) > > > > > Maybe the https://github.com/vincentbernat/lldpd/blob/branch-0.7/NEWS > > could also be helpful. > > Yes, I updated the minimum kernel version in the oldies option and added an > option for custom TLVs. > > > > > I would be happy if you could have a look into this, I'm also interested > > in an updated package, but didn't have time to investigate this further > > yet. ;-) > > Privilege separation options are OK. > I did not enable seccomp because they do not use the syscall directly but > through libseccomp which is not in ptxdist. Also, it is not yet enabled by > default by the developer, so I think this can wait a little bit. > > lldpd works on my system with busybox init. > I do not have a systemd box with ptxdist however. (It should detect the correct > location via pkg-config, right?) > Would be great if you could give the v2 patch a try, especially wrt systemd. > > > > > Greets > > Alex > > > > -- > > »With the first link, the chain is forged. The first speech censured, > > the first thought forbidden, the first freedom denied, chains us all > > irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie) > > *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601 D1D5 8FBA 7744 CC87 10D0 *** > > Thanks, > Clemens Hi Alexander, did you have time to try my lldpd patch? It's running on my busybox system since then. So far, no problems! Could you please help me test lldpd in a systemd environment? Thanks. Clemens _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] lldpd: bump version to 0.7.19 2015-11-16 13:11 ` Clemens Gruber @ 2015-11-16 13:26 ` Alexander Dahl 2015-11-22 17:46 ` Clemens Gruber 0 siblings, 1 reply; 6+ messages in thread From: Alexander Dahl @ 2015-11-16 13:26 UTC (permalink / raw) To: Clemens Gruber; +Cc: ptxdist Hei hei, Am 2015-11-16 14:11, schrieb Clemens Gruber: > did you have time to try my lldpd patch? Not yet. I try to put it in between somewhere this week. > It's running on my busybox system since then. So far, no problems! :-) > Could you please help me test lldpd in a systemd environment? We're still using bbinit here, didn't have time to play with systemd for three years now. :-( Greets Alex -- »With the first link, the chain is forged. The first speech censured, the first thought forbidden, the first freedom denied, chains us all irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie) *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601 D1D5 8FBA 7744 CC87 10D0 *** _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] lldpd: bump version to 0.7.19 2015-11-16 13:26 ` Alexander Dahl @ 2015-11-22 17:46 ` Clemens Gruber 0 siblings, 0 replies; 6+ messages in thread From: Clemens Gruber @ 2015-11-22 17:46 UTC (permalink / raw) To: Alexander Dahl; +Cc: Michael Olbrich, ptxdist Hi, On Mon, Nov 16, 2015 at 02:26:53PM +0100, Alexander Dahl wrote: > We're still using bbinit here, didn't have time to play with systemd for > three years now. :-( I am setting up systemd right now on a test machine. Michael: Please don't merge the lldpd patch yet, I'll add the systemd support as well. Checking if PTXCONF_INITMETHOD_SYSTEMD is defined should be enough, right? Or do we need a separate option for systemd in lldpd.in? Thanks, Clemens _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-22 17:46 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-07 17:26 [ptxdist] [PATCH] lldpd: bump version to 0.7.19 Clemens Gruber 2015-11-09 7:46 ` Alexander Dahl 2015-11-09 9:58 ` Clemens Gruber 2015-11-16 13:11 ` Clemens Gruber 2015-11-16 13:26 ` Alexander Dahl 2015-11-22 17:46 ` Clemens Gruber
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox