Re: [ptxdist] [PATCH] lldpd: bump version to 0.7.19

[Clemens Gruber <clemens.gruber@pqgruber.com>]

Hi Alexander,

On Mon, Nov 09, 2015 at 08:46:09AM +0100, Alexander Dahl wrote:
> Hei hei, 
> 
> Am 2015-11-07 18:26, schrieb Clemens Gruber:
> > -LLDPD_VERSION	:= 0.7.6
> > -LLDPD_MD5		:= dbd90a68b91448dcb94a4a77c5d8ef65
> > +LLDPD_VERSION	:= 0.7.19
> > +LLDPD_MD5		:= 4e924420e00ccd5dc289506f43221820
> 
> I'm afraid it's not that simple. Some configure options changed and some
> where added. This should be adressed in rules/lldpd.make and maybe in
> rules/lldpd.in as well. I attach a diff of the output of ./configure
> --help to this mail.
> 
> Another point is to check the new pid file handling. There's a new
> option --with-lldpd-pid-file in the configure output which should be
> checked against projectroot/etc/init.d/lldpd which is the startup script
> for bbinit.

This works out of the box. It uses /var/run/lldpd.pid by default.

> 
> The new possibility to link against json-c should be checked. There
> seems to be some new support for systemd. The with-privsep options
> should also be checked, there were some upstream changes in lldpd 0.7.8.

In v2, I added an option to enable the JSON output format (but only with json-c
as we do not have Jansson in ptxdist)

> 
> Maybe the https://github.com/vincentbernat/lldpd/blob/branch-0.7/NEWS
> could also be helpful.

Yes, I updated the minimum kernel version in the oldies option and added an
option for custom TLVs.

> 
> I would be happy if you could have a look into this, I'm also interested
> in an updated package, but didn't have time to investigate this further
> yet. ;-)

Privilege separation options are OK.
I did not enable seccomp because they do not use the syscall directly but
through libseccomp which is not in ptxdist. Also, it is not yet enabled by
default by the developer, so I think this can wait a little bit.

lldpd works on my system with busybox init.
I do not have a systemd box with ptxdist however. (It should detect the correct
location via pkg-config, right?)
Would be great if you could give the v2 patch a try, especially wrt systemd.

> 
> Greets
> Alex
> 
> -- 
> »With the first link, the chain is forged. The first speech censured,
> the first thought forbidden, the first freedom denied, chains us all
> irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
> *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

Thanks,
Clemens

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de