Re: [ptxdist] [PATCH] glib: Patch glib-2.0.pc.in to use '-isystem dir' rather than '-Idir'

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Oct 16, 2015 at 10:02:59AM -0400, Jon Ringle wrote:
> Ping...
> 
> On Sat, Oct 3, 2015 at 9:11 AM, Jon Ringle <jon@ringle.org> wrote:
> > On Sat, Oct 3, 2015 at 4:56 AM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> >> On 10/03/2015 05:06 AM, jon@ringle.org wrote:
> >>> From: Jon Ringle <jringle@gridpoint.com>
> >>>
> >>> When ptxdist did a bump to glib-2.44.0, a project that uses glib and builds
> >>> with -Werror will fail.
> >>>
> >>> This patch will allow projects that use -Werror to continue to build without
> >>> error.
> >>>
> >>> This patch was submitted upstream:
> >>> https://bugzilla.gnome.org/show_bug.cgi?id=756005

I agree with the comments on the bug report. Also, I don't think I've seen
these warnings with other packages that use glib. What exactly are you
doing to trigger these warning?

Regards,
Michael

> >>>
> >>> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> >>> ---
> >>>  ....0.pc.in-use-isystem-dir-rather-than-Idir.patch | 90 ++++++++++++++++++++++
> >>>  patches/glib-2.44.0/series                         |  4 +
> >>>  2 files changed, 94 insertions(+)
> >>>  create mode 100644 patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch
> >>>  create mode 100644 patches/glib-2.44.0/series
> >>>
> >>> diff --git a/patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch b/patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch
> >>> new file mode 100644
> >>> index 0000000..c524878
> >>> --- /dev/null
> >>> +++ b/patches/glib-2.44.0/0001-glib-2.0.pc.in-use-isystem-dir-rather-than-Idir.patch
> >>> @@ -0,0 +1,90 @@
> >>> +From: Jon Ringle <jringle@gridpoint.com>
> >>> +Date: Fri, 2 Oct 2015 22:44:07 -0400
> >>> +Subject: [PATCH] glib-2.0.pc.in: use '-isystem dir' rather than '-Idir'
> >>> +
> >>> +glib produces warnings in that gcc will turn to errors when a project builds
> >>> +with -Werror:
> >>> +/usr/include/glib-2.0/gio/glistmodel.h: In function 'GListModel* G_LIST_MODEL(gconstpointer)':
> >>    ^^^^^^^^^^^^^^^^^^^^^
> >>
> >> this doesn't look correct when cross compiling.
> >
> > Maybe I shouldn't have done so, but for the purpose of the patch being
> > sent upstream, I stripped off the leading part of the path. They all
> > look like:
> > /home/local/GRIDPOINT/jringle/code/gpec/ec1k-rootfs/platform-EC1K/sysroot-target/usr/include/glib-2.0/gio/glistmodel.h:
> > In function 'GListModel* G_LIST_MODEL(gconstpointer)':
> >
> > -Jon
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de