From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] Possible Patch: Qt 5.4.2
Date: Fri, 17 Jul 2015 10:20:44 +0200 [thread overview]
Message-ID: <20150717082044.GD26620@pengutronix.de> (raw)
In-Reply-To: <loom.20150716T090826-151@post.gmane.org>
On Thu, Jul 16, 2015 at 07:18:09AM +0000, Dennis Miller wrote:
> Hi,
>
> I've managed to convert my BSP to PTXdist 2015.07.0 and I think
> I've found a small error in the qt5.make file.
>
> During qt5.install this is done:
>
> ifdef PTXCONF_QT5_MODULE_QTWEBKIT
> @chrpath -d $(QT5_PKGDIR)/usr/lib/qt5/libexec/QtWebProcess
> @chrpath -d $(QT5_PKGDIR)/usr/lib/qt5/libexec/QtWebPluginProcess
> endif
>
> QtWebPluginProcess did not get build in my configuration - I guess this
> is fine since the following happens during qt5.targetinstall:
>
> ifdef PTXCONF_QT5_MODULE_QTWEBKIT_QUICK
> @$(call install_copy, qt5, 0, 0, 0755, -, \
> /usr/lib/qt5/libexec/QtWebProcess)
> ifdef PTXCONF_QT5_X11
> @$(call install_copy, qt5, 0, 0, 0755, -, \
> /usr/lib/qt5/libexec/QtWebPluginProcess)
> endif
> endif
>
> -> So QtWebPluginProcess is only installed (and possibly build) for X11
> configurations and I am building for a framebuffer device.
>
> The following patch simply copies this behavior.
> Please note that I have not yet tested this!
This looks right. Can you please create a proper patch for this?
Michael
> ------------------------------------------------------------------------
> /ptxdist-2015.07.0/rules$ diff -rupN qt5.make.original qt5.make
> --- qt5.make.original 2015-07-16 09:04:38.395523870 +0200
> +++ qt5.make 2015-07-16 09:06:18.115526883 +0200
> @@ -232,10 +232,12 @@ $(STATEDIR)/qt5.install:
> @$(call targetinfo)
> @$(call world/install, QT5)
> @find $(QT5_PKGDIR) -name '*.qmltypes' | xargs -r rm
> -ifdef PTXCONF_QT5_MODULE_QTWEBKIT
> +ifdef PTXCONF_QT5_MODULE_QTWEBKIT_QUICK
> @chrpath -d $(QT5_PKGDIR)/usr/lib/qt5/libexec/QtWebProcess
> +ifdef PTXCONF_QT5_X11
> @chrpath -d $(QT5_PKGDIR)/usr/lib/qt5/libexec/QtWebPluginProcess
> endif
> +endif
> @$(call touch)
>
> QT5_QT_CONF := $(PTXDIST_SYSROOT_CROSS)/bin/qt5/qt.conf
> ------------------------------------------------------------------------
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2015-07-17 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 7:18 Dennis Miller
2015-07-17 8:20 ` Michael Olbrich [this message]
2015-07-17 12:11 ` [ptxdist] [PATCH] qt5: fix install step for non-x11 builds Dennis Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717082044.GD26620@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox