mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] busybox: add crond systemd service
Date: Tue, 14 Jul 2015 14:36:10 +0200	[thread overview]
Message-ID: <20150714123610.GE30722@pengutronix.de> (raw)
In-Reply-To: <CAHChq8MZDakhR-9NXO6XbkaHHmz9+wyBNxbhyCbnH0ARFbKiVQ@mail.gmail.com>

On Wed, Jul 08, 2015 at 08:25:17PM +0200, Albert Antony wrote:
> Signed-off-by: Albert Antony <albert@newtec.dk>

Looks good. However the patch does not apply. I think you email client
replaced all tabs.

Michael

> ---
>  projectroot/lib/systemd/system/crond.service | 11 +++++++++++
>  rules/busybox.in                             |  6 ++++++
>  rules/busybox.make                           |  7 +++++++
>  3 files changed, 24 insertions(+)
>  create mode 100644 projectroot/lib/systemd/system/crond.service
> 
> diff --git a/projectroot/lib/systemd/system/crond.service
> b/projectroot/lib/systemd/system/crond.service
> new file mode 100644
> index 0000000..b650ae5
> --- /dev/null
> +++ b/projectroot/lib/systemd/system/crond.service
> @@ -0,0 +1,11 @@
> +[Unit]
> +Description=Cron Daemon
> +After=syslog.service
> +
> +[Service]
> +Type=forking
> +ExecStart=/usr/sbin/crond -b
> +Restart=always
> +
> +[Install]
> +WantedBy=multi-user.target
> diff --git a/rules/busybox.in b/rules/busybox.in
> index 7a41e7c..7bcdc94 100644
> --- a/rules/busybox.in
> +++ b/rules/busybox.in
> @@ -90,6 +90,12 @@ config BUSYBOX_TELNETD_SYSTEMD_UNIT
>   depends on BUSYBOX_TELNETD && SYSTEMD
>   prompt "telnetd systemd service files"
> 
> +config BUSYBOX_CROND_SYSTEMD_UNIT
> + bool
> + default y
> + depends on BUSYBOX_CROND && SYSTEMD
> + prompt "crond systemd service files"
> +
>  comment "---"
> 
>  source "config/busybox/Config.in"
> diff --git a/rules/busybox.make b/rules/busybox.make
> index 60191c2..d2c9990 100644
> --- a/rules/busybox.make
> +++ b/rules/busybox.make
> @@ -224,6 +224,13 @@ ifdef PTXCONF_BUSYBOX_TELNETD_SYSTEMD_UNIT
>   /lib/systemd/system/sockets.target.wants/telnetd.socket)
>  endif
> 
> +ifdef PTXCONF_BUSYBOX_CROND_SYSTEMD_UNIT
> + @$(call install_alternative, busybox, 0, 0, 0644, \
> + /lib/systemd/system/crond.service)
> + @$(call install_link, busybox, ../crond.service, \
> + /lib/systemd/system/multi-user.target.wants/crond.service)
> +endif
> +
>  # #
>  # # config files
>  # #
> -- 
> 2.0.0

> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2015-07-14 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 18:25 Albert Antony
2015-07-14 12:36 ` Michael Olbrich [this message]
2015-07-08 18:27 Albert Antony
2015-07-15 12:56 Albert Antony
2015-07-17  8:25 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150714123610.GE30722@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox