* [ptxdist] [PATCH] udev: fix error on kernels without uevent helpers
@ 2015-06-23 14:18 Clemens Gruber
2015-07-01 8:07 ` Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Clemens Gruber @ 2015-06-23 14:18 UTC (permalink / raw)
To: ptxdist; +Cc: Clemens Gruber
Current kernel docs recommend disabling CONFIG_UEVENT_HELPER.
If disabled however, the following error message is shown:
/etc/rc.d/S00udev: line 95: can't create /proc/sys/kernel/hotplug:
nonexistent directory
This patch fixes it by checking if /proc/sys/kernel/hotplug exists.
Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
projectroot/etc/init.d/udev | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/projectroot/etc/init.d/udev b/projectroot/etc/init.d/udev
index 1020b40..a7722b7 100644
--- a/projectroot/etc/init.d/udev
+++ b/projectroot/etc/init.d/udev
@@ -50,7 +50,9 @@ start)
# udev handles uevents itself, so we don't need to have
# the kernel call out to any binary in response to them
- echo > /proc/sys/kernel/hotplug
+ if [ -e /proc/sys/kernel/hotplug ]; then
+ echo > /proc/sys/kernel/hotplug
+ fi
echo "creating static nodes"
make_extra_nodes
--
2.4.4
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] udev: fix error on kernels without uevent helpers
2015-06-23 14:18 [ptxdist] [PATCH] udev: fix error on kernels without uevent helpers Clemens Gruber
@ 2015-07-01 8:07 ` Michael Olbrich
2015-07-01 8:08 ` Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Michael Olbrich @ 2015-07-01 8:07 UTC (permalink / raw)
To: ptxdist
On Tue, Jun 23, 2015 at 04:18:00PM +0200, Clemens Gruber wrote:
> Current kernel docs recommend disabling CONFIG_UEVENT_HELPER.
>
> If disabled however, the following error message is shown:
> /etc/rc.d/S00udev: line 95: can't create /proc/sys/kernel/hotplug:
> nonexistent directory
>
> This patch fixes it by checking if /proc/sys/kernel/hotplug exists.
>
> Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Thanks, applied.
Michael
> ---
> projectroot/etc/init.d/udev | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/projectroot/etc/init.d/udev b/projectroot/etc/init.d/udev
> index 1020b40..a7722b7 100644
> --- a/projectroot/etc/init.d/udev
> +++ b/projectroot/etc/init.d/udev
> @@ -50,7 +50,9 @@ start)
>
> # udev handles uevents itself, so we don't need to have
> # the kernel call out to any binary in response to them
> - echo > /proc/sys/kernel/hotplug
> + if [ -e /proc/sys/kernel/hotplug ]; then
> + echo > /proc/sys/kernel/hotplug
> + fi
>
> echo "creating static nodes"
> make_extra_nodes
> --
> 2.4.4
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] udev: fix error on kernels without uevent helpers
2015-07-01 8:07 ` Michael Olbrich
@ 2015-07-01 8:08 ` Michael Olbrich
0 siblings, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2015-07-01 8:08 UTC (permalink / raw)
To: ptxdist
On Wed, Jul 01, 2015 at 10:07:42AM +0200, Michael Olbrich wrote:
> On Tue, Jun 23, 2015 at 04:18:00PM +0200, Clemens Gruber wrote:
> > Current kernel docs recommend disabling CONFIG_UEVENT_HELPER.
> >
> > If disabled however, the following error message is shown:
> > /etc/rc.d/S00udev: line 95: can't create /proc/sys/kernel/hotplug:
> > nonexistent directory
> >
> > This patch fixes it by checking if /proc/sys/kernel/hotplug exists.
> >
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
>
> Thanks, applied.
Not this on, the v2.
Michael
> > ---
> > projectroot/etc/init.d/udev | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/projectroot/etc/init.d/udev b/projectroot/etc/init.d/udev
> > index 1020b40..a7722b7 100644
> > --- a/projectroot/etc/init.d/udev
> > +++ b/projectroot/etc/init.d/udev
> > @@ -50,7 +50,9 @@ start)
> >
> > # udev handles uevents itself, so we don't need to have
> > # the kernel call out to any binary in response to them
> > - echo > /proc/sys/kernel/hotplug
> > + if [ -e /proc/sys/kernel/hotplug ]; then
> > + echo > /proc/sys/kernel/hotplug
> > + fi
> >
> > echo "creating static nodes"
> > make_extra_nodes
> > --
> > 2.4.4
> >
> >
> > --
> > ptxdist mailing list
> > ptxdist@pengutronix.de
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-01 6:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-23 14:18 [ptxdist] [PATCH] udev: fix error on kernels without uevent helpers Clemens Gruber
2015-07-01 8:07 ` Michael Olbrich
2015-07-01 8:08 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox