Re: [ptxdist] [PATCH] sox: new package for SoX 14.4.2

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Apr 18, 2015 at 02:40:51AM +0200, Andreas Pretzsch wrote:
> SoX is the Swiss Army Knife of sound processing utilities.
> It can convert audio files to other popular audio file types
> and also apply sound effects and filters during the conversion.
> See http://sox.sourceforge.net/ for more information.
> 
> In addition to libsox, optionally the command-line tool "sox"
> and its shortcuts "soxi", "play", "rec" can be installed.
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> ---
> The "--disable-openmp" is required, as sox configure detects
> OpenMP support.............yes, -fopenmp
> but won't run on targets without libgomp (GCC OpenMP) or similar.
> As I don't care about this here (probably like most users), just
> disable it, like some other packages in ptxdist do it.
> 
> Regarding other configure options (like mp3 support and whatnot),
> rely on configure auto-detection, instead of adding with/without
> options by the dozen. Whoever needs this is welcome to step in.
> 
>  rules/sox.in   | 46 +++++++++++++++++++++++++++++++++++++++++++
>  rules/sox.make | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 108 insertions(+)
>  create mode 100644 rules/sox.in
>  create mode 100644 rules/sox.make
> 
> diff --git a/rules/sox.in b/rules/sox.in
> new file mode 100644
> index 0000000..0622f3e
> --- /dev/null
> +++ b/rules/sox.in
> @@ -0,0 +1,46 @@
> +## SECTION=multimedia_sound
> +
> +menuconfig SOX
> +	tristate
> +	prompt "sox                           "
> +	help
> +	  SoX is the Swiss Army Knife of sound processing utilities.
> +	  It can convert audio files to other popular audio file types
> +	  and also apply sound effects and filters during the conversion.
> +	  See http://sox.sourceforge.net/ for more information.
> +
> +if SOX
> +
> +config SOX_SOX
> +	bool
> +	default y
> +	prompt "Install sox command-line tool"
> +	help
> +	  Install command-line tool providing all libSoX functionality.
> +	  Note: libsox is installed regardless of this option.
> +
> +config SOX_SOXI
> +	bool
> +	depends on SOX_SOX
> +	prompt "Install symlink soxi => sox"
> +	help
> +	  Add "soxi" command to display sound file metadata.
> +	  Same effect can be achieved with "sox --info".

I think we can just install this with sox

> +
> +config SOX_PLAY
> +	bool
> +	depends on SOX_SOX
> +	prompt "Install symlink play => sox"
> +	help
> +	  Add "play" command to use sox for basic playing.
> +	  Same effect can be achieved with "sox <file> -d".
> +
> +config SOX_REC
> +	bool
> +	depends on SOX_SOX
> +	prompt "Install symlink rec => sox"
> +	help
> +	  Add "rec" command to use sox for basic recording.
> +	  Same effect can be achieved with "sox -d <file>".

Same for these two, or maybe one option for both.

> +
> +endif
> diff --git a/rules/sox.make b/rules/sox.make
> new file mode 100644
> index 0000000..bd03bdc
> --- /dev/null
> +++ b/rules/sox.make
> @@ -0,0 +1,62 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 by Andreas Pretzsch <apr@cn-eng.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +PACKAGES-$(PTXCONF_SOX) += sox
> +
> +SOX_VERSION	:= 14.4.2
> +SOX_MD5		:= ba804bb1ce5c71dd484a102a5b27d0dd
> +SOX		:= sox-$(SOX_VERSION)
> +SOX_SUFFIX	:= tar.bz2
> +SOX_URL		:= $(call ptx/mirror, SF, sox/$(SOX).$(SOX_SUFFIX))
> +SOX_SOURCE	:= $(SRCDIR)/$(SOX).$(SOX_SUFFIX)
> +SOX_DIR		:= $(BUILDDIR)/$(SOX)
> +SOX_LICENSE	:= GPLv2+ (tools), LGPLv2.1+ (libs)
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +SOX_CONF_TOOL	:= autoconf
> +SOX_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	--disable-openmp

You're missing a lot of options here and probably some depencencies in the
.in file as well. Use the global largefile option, --disable-dl-*,
--ensable-symlinks, and either disable, enable (with correct dependency) or
add an option (use ptx/wwo for configure) for each exernal dependency.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/sox.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, sox)
> +	@$(call install_fixup, sox,PRIORITY,optional)
> +	@$(call install_fixup, sox,SECTION,base)
> +	@$(call install_fixup, sox,AUTHOR,"Andreas Pretzsch <apr@cn-eng.de>")
> +	@$(call install_fixup, sox,DESCRIPTION,"Sound eXchange, the Swiss Army knife of audio manipulation")
> +
> +	@$(call install_lib, sox, 0, 0, 0644, libsox)
> +ifdef PTXCONF_SOX_SOX
> +	@$(call install_copy, sox, 0, 0, 0755, -, /usr/bin/sox)
> +endif
> +ifdef PTXCONF_SOX_SOXI
> +	@$(call install_link, sox, sox, /usr/bin/soxi)
> +endif
> +ifdef PTXCONF_SOX_PLAY
> +	@$(call install_link, sox, sox, /usr/bin/play)
> +endif
> +ifdef PTXCONF_SOX_REC
> +	@$(call install_link, sox, sox, /usr/bin/rec)
> +endif
> +
> +	@$(call install_finish, sox)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.1.3
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de