From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <rsc@pengutronix.de>) id 1Yfryz-00010U-55
	for ptxdist@pengutronix.de; Wed, 08 Apr 2015 17:33:37 +0200
Received: from rsc by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <rsc@pengutronix.de>) id 1Yfryz-0001HT-3u
	for ptxdist@pengutronix.de; Wed, 08 Apr 2015 17:33:37 +0200
Date: Wed, 8 Apr 2015 17:33:37 +0200
From: Robert Schwebel <r.schwebel@pengutronix.de>
Message-ID: <20150408153337.GV8272@pengutronix.de>
References: <1427898644-7511-1-git-send-email-oliver.graute@neuhaus.de>
	<551D0C71.7040402@pengutronix.de>
	<OFCB2F2E93.3C440140-ONC1257E21.004F33C7-C1257E21.004F9AEC@neuhaus.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <OFCB2F2E93.3C440140-ONC1257E21.004F33C7-C1257E21.004F9AEC@neuhaus.de>
Subject: Re: [ptxdist] Antwort: Re: [PATCHv1 1/1] quagga: this patch adds
 quagga support to ptxdist
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, Apr 08, 2015 at 04:29:22PM +0200, Oliver.Graute@neuhaus.de wrote:
> 
> > builds here.
> >
> > Please fix:
> > - remove default CONF_ENV
> > - remove default stages: compile, install
> > - the install_alternative for the config files is a good idea,
> >   however /etc/*.sample is probably not used by quagga.
> >   Please provide a set of config files as /etc/* (without .sample) in
> >   this patch. I'm not sure if this a sensible option, beacuse quagga
> >   probsably supports a lot of routing deamon which need different files.
> 
> > > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> > > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)
> 
> should I remove these install copy lines completly? because if i only remove
> .sample install_copy would fail.

As Marc said: if you provide a set of config files as /etc/* (without
.sample), install_copy won't fail if you remove the .sample from the
paths.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de