Re: [ptxdist] Antwort: Re: [PATCHv1 1/1] quagga: this patch adds quagga support to ptxdist

[Robert Schwebel <r.schwebel@pengutronix.de>]

On Wed, Apr 08, 2015 at 04:29:22PM +0200, Oliver.Graute@neuhaus.de wrote:
> 
> > builds here.
> >
> > Please fix:
> > - remove default CONF_ENV
> > - remove default stages: compile, install
> > - the install_alternative for the config files is a good idea,
> >   however /etc/*.sample is probably not used by quagga.
> >   Please provide a set of config files as /etc/* (without .sample) in
> >   this patch. I'm not sure if this a sensible option, beacuse quagga
> >   probsably supports a lot of routing deamon which need different files.
> 
> > > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/ripd.conf.sample)
> > > +   @$(call install_copy, quagga, 0, 0, 0644, -, /etc/zebra.conf.sample)
> 
> should I remove these install copy lines completly? because if i only remove
> .sample install_copy would fail.

As Marc said: if you provide a set of config files as /etc/* (without
.sample), install_copy won't fail if you remove the .sample from the
paths.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de