Re: [ptxdist] [PATCH 1/2] host-certdata: root CA certificate bundle downloader

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

sorry for the late reply.

On Fri, Jan 16, 2015 at 12:58:44PM +0100, Bruno Thomsen wrote:
> From: Bruno Thomsen <bth@kamstrup.com>
> 
> Added a new host dummy package that download a specific firefox bundle
> of root CA certificates. This functionality is used by libcurl package.
> 
> Signed-off-by: Bruno Thomsen <bth@kamstrup.com>
> ---
>  rules/host-certdata.in   |  5 +++++
>  rules/host-certdata.make | 57 ++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 62 insertions(+)
>  create mode 100644 rules/host-certdata.in
>  create mode 100644 rules/host-certdata.make
> 
> diff --git a/rules/host-certdata.in b/rules/host-certdata.in
> new file mode 100644
> index 0000000..087f34c
> --- /dev/null
> +++ b/rules/host-certdata.in
> @@ -0,0 +1,5 @@
> +## SECTION=hosttools_noprompt
> +
> +config HOST_CERTDATA
> +	tristate
> +
> diff --git a/rules/host-certdata.make b/rules/host-certdata.make
> new file mode 100644
> index 0000000..0bdccc4
> --- /dev/null
> +++ b/rules/host-certdata.make
> @@ -0,0 +1,57 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 by Bruno Thomsen <bth@kamstrup.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_CERTDATA) += host-certdata
> +
> +#
> +# Paths and names
> +#
> +FIREFOX_MAJOR_VERSION	:= 33
> +FIREFOX_MINOR_VERSION	:= 0
> +HOST_CERTDATA_VERSION	:= $(FIREFOX_MAJOR_VERSION)_$(FIREFOX_MINOR_VERSION)
> +HOST_CERTDATA_MD5	:= c9a187ce3bcd6d5ee1f8f5f531cf97f9
> +HOST_CERTDATA		:= certdata
> +HOST_CERTDATA_SUFFIX	:= txt
> +HOST_CERTDATA_URL	:= \
> +	http://hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_$(HOST_CERTDATA_VERSION)_RELEASE/security/nss/lib/ckfw/builtins/$(HOST_CERTDATA).$(HOST_CERTDATA_SUFFIX)
> +HOST_CERTDATA_SOURCE	:= $(SRCDIR)/$(HOST_CERTDATA).$(HOST_CERTDATA_SUFFIX)

> +HOST_CERTDATA_DIR	:= $(HOST_BUILDDIR)/$(HOST_CERTDATA)-$(HOST_CERTDATA_VERSION)

Remove this line.

> +
> +# ----------------------------------------------------------------------------
> +# Extract
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/host-certdata.extract:
> +	@$(call targetinfo)

> +	@$(call clean, $(HOST_CERTDATA_DIR))

Remove this line.

> +	@mkdir -p $(HOST_CERTDATA_DIR)
> +	@cp $(HOST_CERTDATA_SOURCE) $(HOST_CERTDATA_DIR)

Move this to host-certdata.install and use $(HOST_CERTDATA_PKGDIR)/share/certdata/
We prefer to avoid referencing <PKG>_DIRs from other packages.

> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/host-certdata.compile:
> +	@$(call targetinfo)
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/host-certdata.install:
> +	@$(call targetinfo)
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.9.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de