From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Yb3iX-00048L-VH
	for ptxdist@pengutronix.de; Thu, 26 Mar 2015 10:04:45 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1Yb3iX-0007ct-TO
	for ptxdist@pengutronix.de; Thu, 26 Mar 2015 10:04:45 +0100
Date: Thu, 26 Mar 2015 10:04:45 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20150326090445.GS3000@pengutronix.de>
References: <1427097120-25809-1-git-send-email-r.schwebel@pengutronix.de>
	<20150323075942.GC8272@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20150323075942.GC8272@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] hackbench: remove obsolete package
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Mar 23, 2015 at 08:59:42AM +0100, Robert Schwebel wrote:
> Michael,
> 
> On Mon, Mar 23, 2015 at 08:52:00AM +0100, Robert Schwebel wrote:
> > +#
> > +# from   : ptxdist-2015.02.0
> > +# to     : ptxdist-2015.03.0
> > +# symbol : HACKBENCH -> RT_TESTS_HACKBENCH
> > +# reason : old tool obsolete, new version is from rt-tests
> > +#
> > +s/^\(\(# \)PTXCONF_\)HACKBENCH/\1RT_TESTS_HACKBENCH/
> > +s/^PTXCONF_HACKBENCH=\([ym]\)/PTXCONF_RT_TESTS_HACKBENCH=y\nPTXCONF_RT_TESTS=\1/
> 
> I tried the trick you suggested, but I'm still not entirely happy:
> 
> - I get a warning during migration:
>   .config:2062:warning: override: reassigning to symbol RT_TESTS_HACKBENCH

It' only happens once during migrate, and that's ok.

> - There are still cases of RT_TESTS already being set to either y or m
>   where the migration helper does the wrong thing.
> 
> Better ideas, anyone?

I've simplified it a bit while applying, broke it and fixed it again.
It works as I would expect it:

RT_TESTS will remain as is, when it's already enabled. I don't think
anything else makes sense.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de