From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] hackbench: remove obsolete package
Date: Thu, 26 Mar 2015 10:04:45 +0100 [thread overview]
Message-ID: <20150326090445.GS3000@pengutronix.de> (raw)
In-Reply-To: <20150323075942.GC8272@pengutronix.de>
On Mon, Mar 23, 2015 at 08:59:42AM +0100, Robert Schwebel wrote:
> Michael,
>
> On Mon, Mar 23, 2015 at 08:52:00AM +0100, Robert Schwebel wrote:
> > +#
> > +# from : ptxdist-2015.02.0
> > +# to : ptxdist-2015.03.0
> > +# symbol : HACKBENCH -> RT_TESTS_HACKBENCH
> > +# reason : old tool obsolete, new version is from rt-tests
> > +#
> > +s/^\(\(# \)PTXCONF_\)HACKBENCH/\1RT_TESTS_HACKBENCH/
> > +s/^PTXCONF_HACKBENCH=\([ym]\)/PTXCONF_RT_TESTS_HACKBENCH=y\nPTXCONF_RT_TESTS=\1/
>
> I tried the trick you suggested, but I'm still not entirely happy:
>
> - I get a warning during migration:
> .config:2062:warning: override: reassigning to symbol RT_TESTS_HACKBENCH
It' only happens once during migrate, and that's ok.
> - There are still cases of RT_TESTS already being set to either y or m
> where the migration helper does the wrong thing.
>
> Better ideas, anyone?
I've simplified it a bit while applying, broke it and fixed it again.
It works as I would expect it:
RT_TESTS will remain as is, when it's already enabled. I don't think
anything else makes sense.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2015-03-26 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 7:52 Robert Schwebel
2015-03-23 7:59 ` Robert Schwebel
2015-03-26 9:04 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326090445.GS3000@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox