* [ptxdist] [PATCH] libkmod: version bump 18 -> 20 @ 2015-03-06 18:48 Robert Schwebel 2015-03-06 19:39 ` Uwe Kleine-König 2015-03-26 8:48 ` Michael Olbrich 0 siblings, 2 replies; 6+ messages in thread From: Robert Schwebel @ 2015-03-06 18:48 UTC (permalink / raw) To: ptxdist; +Cc: Robert Schwebel We have a new option for code coverage, which shall be disabled by default. Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> --- rules/libkmod.make | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/rules/libkmod.make b/rules/libkmod.make index ab88923..d0e3c6a 100644 --- a/rules/libkmod.make +++ b/rules/libkmod.make @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBKMOD) += libkmod # # Paths and names # -LIBKMOD_VERSION := 19 -LIBKMOD_MD5 := a08643f814aa4efc12211c6e5909f4d9 +LIBKMOD_VERSION := 20 +LIBKMOD_MD5 := d6f4fef718a50bd88080de6a43bc64d8 LIBKMOD := kmod-$(LIBKMOD_VERSION) LIBKMOD_SUFFIX := tar.xz LIBKMOD_URL := $(call ptx/mirror, KERNEL, utils/kernel/kmod/$(LIBKMOD).$(LIBKMOD_SUFFIX)) @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT := \ --disable-gtk-doc-html \ --disable-gtk-doc-pdf \ --without-xz \ - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ + --disable-coverage # ---------------------------------------------------------------------------- # Target-Install -- 2.1.4 -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20 2015-03-06 18:48 [ptxdist] [PATCH] libkmod: version bump 18 -> 20 Robert Schwebel @ 2015-03-06 19:39 ` Uwe Kleine-König 2015-03-06 19:54 ` Robert Schwebel 2015-03-26 8:48 ` Michael Olbrich 1 sibling, 1 reply; 6+ messages in thread From: Uwe Kleine-König @ 2015-03-06 19:39 UTC (permalink / raw) To: ptxdist; +Cc: Robert Schwebel Hey Robert, On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote: > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT := \ > --disable-gtk-doc-html \ > --disable-gtk-doc-pdf \ > --without-xz \ > - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib > + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ > + --disable-coverage If you add a \ to the coverage line it doesn't need to be touched next time a new option is added. Best regards Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20 2015-03-06 19:39 ` Uwe Kleine-König @ 2015-03-06 19:54 ` Robert Schwebel 2015-03-07 9:23 ` Uwe Kleine-König 0 siblings, 1 reply; 6+ messages in thread From: Robert Schwebel @ 2015-03-06 19:54 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: ptxdist On Fri, Mar 06, 2015 at 08:39:14PM +0100, Uwe Kleine-König wrote: > Hey Robert, > > On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote: > > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT := \ > > --disable-gtk-doc-html \ > > --disable-gtk-doc-pdf \ > > --without-xz \ > > - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib > > + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ > > + --disable-coverage > If you add a \ to the coverage line it doesn't need to be touched next > time a new option is added. I don't think we do this for other packages. rsc -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20 2015-03-06 19:54 ` Robert Schwebel @ 2015-03-07 9:23 ` Uwe Kleine-König 2015-03-21 13:34 ` Michael Olbrich 0 siblings, 1 reply; 6+ messages in thread From: Uwe Kleine-König @ 2015-03-07 9:23 UTC (permalink / raw) To: ptxdist Hello Robert, On Fri, Mar 06, 2015 at 08:54:41PM +0100, Robert Schwebel wrote: > On Fri, Mar 06, 2015 at 08:39:14PM +0100, Uwe Kleine-König wrote: > > On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote: > > > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT := \ > > > --disable-gtk-doc-html \ > > > --disable-gtk-doc-pdf \ > > > --without-xz \ > > > - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib > > > + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ > > > + --disable-coverage > > If you add a \ to the coverage line it doesn't need to be touched next > > time a new option is added. > > I don't think we do this for other packages. And this is an excuse not to do it now either? If you agree that it's a good idea, not having done that before shouldn't stop you. After all we never did libkmod 20 before :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20 2015-03-07 9:23 ` Uwe Kleine-König @ 2015-03-21 13:34 ` Michael Olbrich 0 siblings, 0 replies; 6+ messages in thread From: Michael Olbrich @ 2015-03-21 13:34 UTC (permalink / raw) To: ptxdist On Sat, Mar 07, 2015 at 10:23:05AM +0100, Uwe Kleine-König wrote: > On Fri, Mar 06, 2015 at 08:54:41PM +0100, Robert Schwebel wrote: > > On Fri, Mar 06, 2015 at 08:39:14PM +0100, Uwe Kleine-König wrote: > > > On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote: > > > > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT := \ > > > > --disable-gtk-doc-html \ > > > > --disable-gtk-doc-pdf \ > > > > --without-xz \ > > > > - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib > > > > + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ > > > > + --disable-coverage > > > If you add a \ to the coverage line it doesn't need to be touched next > > > time a new option is added. > > > > I don't think we do this for other packages. > And this is an excuse not to do it now either? If you agree that it's a > good idea, not having done that before shouldn't stop you. > > After all we never did libkmod 20 before :-) And we rarely need it. The correct hunk looks like this: @@ -41,6 +41,7 @@ LIBKMOD_CONF_OPT := \ --$(call ptx/endis, PTXCONF_LIBKMOD_LOGGING)-logging \ --$(call ptx/endis, PTXCONF_LIBKMOD_DEBUG)-debug \ --disable-python \ + --disable-coverage \ --disable-gtk-doc \ --disable-gtk-doc-html \ --disable-gtk-doc-pdf \ Most options are added in the middle anyways. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20 2015-03-06 18:48 [ptxdist] [PATCH] libkmod: version bump 18 -> 20 Robert Schwebel 2015-03-06 19:39 ` Uwe Kleine-König @ 2015-03-26 8:48 ` Michael Olbrich 1 sibling, 0 replies; 6+ messages in thread From: Michael Olbrich @ 2015-03-26 8:48 UTC (permalink / raw) To: ptxdist On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote: > We have a new option for code coverage, which shall be disabled by > default. > > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> Thanks, applied (It's already in ptxdist-2015.03.0). Michael > --- > rules/libkmod.make | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/rules/libkmod.make b/rules/libkmod.make > index ab88923..d0e3c6a 100644 > --- a/rules/libkmod.make > +++ b/rules/libkmod.make > @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBKMOD) += libkmod > # > # Paths and names > # > -LIBKMOD_VERSION := 19 > -LIBKMOD_MD5 := a08643f814aa4efc12211c6e5909f4d9 > +LIBKMOD_VERSION := 20 > +LIBKMOD_MD5 := d6f4fef718a50bd88080de6a43bc64d8 > LIBKMOD := kmod-$(LIBKMOD_VERSION) > LIBKMOD_SUFFIX := tar.xz > LIBKMOD_URL := $(call ptx/mirror, KERNEL, utils/kernel/kmod/$(LIBKMOD).$(LIBKMOD_SUFFIX)) > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT := \ > --disable-gtk-doc-html \ > --disable-gtk-doc-pdf \ > --without-xz \ > - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib > + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ > + --disable-coverage > > # ---------------------------------------------------------------------------- > # Target-Install > -- > 2.1.4 > > > -- > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-26 8:48 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-03-06 18:48 [ptxdist] [PATCH] libkmod: version bump 18 -> 20 Robert Schwebel 2015-03-06 19:39 ` Uwe Kleine-König 2015-03-06 19:54 ` Robert Schwebel 2015-03-07 9:23 ` Uwe Kleine-König 2015-03-21 13:34 ` Michael Olbrich 2015-03-26 8:48 ` Michael Olbrich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox