From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1YZJXS-0002rk-Pd for ptxdist@pengutronix.de; Sat, 21 Mar 2015 14:34:06 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1YZJXS-0001Jw-OE for ptxdist@pengutronix.de; Sat, 21 Mar 2015 14:34:06 +0100 Date: Sat, 21 Mar 2015 14:34:06 +0100 From: Michael Olbrich Message-ID: <20150321133406.GJ20453@pengutronix.de> References: <1425667690-17788-1-git-send-email-r.schwebel@pengutronix.de> <20150306193914.GH10717@pengutronix.de> <20150306195441.GC12721@pengutronix.de> <20150307092305.GJ10717@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150307092305.GJ10717@pengutronix.de> Subject: Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20 Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Sat, Mar 07, 2015 at 10:23:05AM +0100, Uwe Kleine-K=F6nig wrote: > On Fri, Mar 06, 2015 at 08:54:41PM +0100, Robert Schwebel wrote: > > On Fri, Mar 06, 2015 at 08:39:14PM +0100, Uwe Kleine-K=F6nig wrote: > > > On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote: > > > > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT :=3D \ > > > > --disable-gtk-doc-html \ > > > > --disable-gtk-doc-pdf \ > > > > --without-xz \ > > > > - --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib > > > > + --$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \ > > > > + --disable-coverage > > > If you add a \ to the coverage line it doesn't need to be touched next > > > time a new option is added. > > = > > I don't think we do this for other packages. > And this is an excuse not to do it now either? If you agree that it's a > good idea, not having done that before shouldn't stop you. > = > After all we never did libkmod 20 before :-) And we rarely need it. The correct hunk looks like this: @@ -41,6 +41,7 @@ LIBKMOD_CONF_OPT :=3D \ --$(call ptx/endis, PTXCONF_LIBKMOD_LOGGING)-logging \ --$(call ptx/endis, PTXCONF_LIBKMOD_DEBUG)-debug \ --disable-python \ + --disable-coverage \ --disable-gtk-doc \ --disable-gtk-doc-html \ --disable-gtk-doc-pdf \ Most options are added in the middle anyways. Michael -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de