Re: [ptxdist] [PATCH] libkmod: version bump 18 -> 20

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Mar 07, 2015 at 10:23:05AM +0100, Uwe Kleine-König wrote:
> On Fri, Mar 06, 2015 at 08:54:41PM +0100, Robert Schwebel wrote:
> > On Fri, Mar 06, 2015 at 08:39:14PM +0100, Uwe Kleine-König wrote:
> > > On Fri, Mar 06, 2015 at 07:48:10PM +0100, Robert Schwebel wrote:
> > > > @@ -45,7 +45,8 @@ LIBKMOD_CONF_OPT	:= \
> > > >  	--disable-gtk-doc-html \
> > > >  	--disable-gtk-doc-pdf \
> > > >  	--without-xz \
> > > > -	--$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib
> > > > +	--$(call ptx/wwo, PTXCONF_LIBKMOD_ZLIB)-zlib \
> > > > +	--disable-coverage
> > > If you add a \ to the coverage line it doesn't need to be touched next
> > > time a new option is added.
> > 
> > I don't think we do this for other packages.
> And this is an excuse not to do it now either? If you agree that it's a
> good idea, not having done that before shouldn't stop you.
> 
> After all we never did libkmod 20 before :-)

And we rarely need it. The correct hunk looks like this:

@@ -41,6 +41,7 @@ LIBKMOD_CONF_OPT	:= \
 	--$(call ptx/endis, PTXCONF_LIBKMOD_LOGGING)-logging \
 	--$(call ptx/endis, PTXCONF_LIBKMOD_DEBUG)-debug \
 	--disable-python \
+	--disable-coverage \
 	--disable-gtk-doc \
 	--disable-gtk-doc-html \
 	--disable-gtk-doc-pdf \

Most options are added in the middle anyways.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de