From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] dropbear: version bump 2014.65 -> 2015.67
Date: Thu, 19 Feb 2015 15:09:25 +0100 [thread overview]
Message-ID: <20150219140925.GL30223@pengutronix.de> (raw)
In-Reply-To: <1424101629-16021-1-git-send-email-bth@kamstrup.com>
On Mon, Feb 16, 2015 at 04:47:09PM +0100, Bruno Thomsen wrote:
> The new version contain options to enable/disable cipher modes.
> Keeping today's default cipher mode.
> In a secure solution one would disable CBC and enable CTR.
>
> Signed-off-by: Bruno Thomsen <bth@kamstrup.com>
> ---
> rules/dropbear.in | 15 +++++++++++++++
> rules/dropbear.make | 18 ++++++++++++++++--
> 2 files changed, 31 insertions(+), 2 deletions(-)
>
> diff --git a/rules/dropbear.in b/rules/dropbear.in
> index fe2ada3..79aad57 100644
> --- a/rules/dropbear.in
> +++ b/rules/dropbear.in
> @@ -203,6 +203,21 @@ config DROPBEAR_TWOFISH256
> bijective f function made by four key-dependent
> 8x8-bit S-boxes.
>
> +config DROPBEAR_CBC_CIPHERS
> + bool
> + prompt "CBC mode ciphers"
> + default y
> + help
> + Enable CBC mode for ciphers. This has security issues though
> + is the most compatible with older SSH implementations.
In that case, shouldn't this be off by default? Those that still need it
can enable it.
Michael
> +
> +config DROPBEAR_CTR_CIPHERS
> + bool
> + prompt "Counter mode ciphers"
> + help
> + Enable "Counter Mode" for ciphers. This is more secure than normal
> + CBC mode against certain attacks. This adds around 1kB to binary
> + size and is recommended for most cases.
>
> comment "Integrity, at least one required --- RFC Draft requires sha1-hmac and recommends sha1-96"
>
> diff --git a/rules/dropbear.make b/rules/dropbear.make
> index f03d0fc..ab9da5d 100644
> --- a/rules/dropbear.make
> +++ b/rules/dropbear.make
> @@ -18,8 +18,8 @@ PACKAGES-$(PTXCONF_DROPBEAR) += dropbear
> #
> # Paths and names
> #
> -DROPBEAR_VERSION := 2014.65
> -DROPBEAR_MD5 := 1918604238817385a156840fa2c39490
> +DROPBEAR_VERSION := 2015.67
> +DROPBEAR_MD5 := e967e320344cd4bfebe321e3ab8514d6
> DROPBEAR := dropbear-$(DROPBEAR_VERSION)
> DROPBEAR_SUFFIX := tar.bz2
> DROPBEAR_URL := http://matt.ucc.asn.au/dropbear/releases/$(DROPBEAR).$(DROPBEAR_SUFFIX)
> @@ -163,7 +163,21 @@ else
> @$(call disable_c, $(DROPBEAR_DIR)/options.h,DROPBEAR_TWOFISH128)
> endif
>
> +ifdef PTXCONF_DROPBEAR_CBC_CIPHERS
> + @echo "ptxdist: enabling cbc ciphers"
> + @$(call enable_c, $(DROPBEAR_DIR)/options.h,DROPBEAR_ENABLE_CBC_MODE)
> +else
> + @echo "ptxdist: disabling cbc ciphers"
> + @$(call disable_c, $(DROPBEAR_DIR)/options.h,DROPBEAR_ENABLE_CBC_MODE)
> +endif
>
> +ifdef PTXCONF_DROPBEAR_CTR_CIPHERS
> + @echo "ptxdist: enabling ctr ciphers"
> + @$(call enable_c, $(DROPBEAR_DIR)/options.h,DROPBEAR_ENABLE_CTR_MODE)
> +else
> + @echo "ptxdist: disabling ctr ciphers"
> + @$(call disable_c, $(DROPBEAR_DIR)/options.h,DROPBEAR_ENABLE_CTR_MODE)
> +endif
>
> ifdef PTXCONF_DROPBEAR_SHA1
> @echo "ptxdist: enabling sha1"
> --
> 1.9.1
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2015-02-19 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:47 Bruno Thomsen
2015-02-19 14:09 ` Michael Olbrich [this message]
2015-02-19 14:48 ` Bruno Thomsen
2015-03-16 13:29 [ptxdist] [PATCH] Dropbear: " Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219140925.GL30223@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox