From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1YORkJ-00041o-64
	for ptxdist@pengutronix.de; Thu, 19 Feb 2015 15:06:27 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1YORkJ-0000FN-4h
	for ptxdist@pengutronix.de; Thu, 19 Feb 2015 15:06:27 +0100
Date: Thu, 19 Feb 2015 15:06:27 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20150219140627.GK30223@pengutronix.de>
References: <1424098273-9461-1-git-send-email-oliver.graute@neuhaus.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1424098273-9461-1-git-send-email-oliver.graute@neuhaus.de>
Subject: Re: [ptxdist] [PATCHv2] c-ares: added c-ares to ptxdist
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Feb 16, 2015 at 03:51:13PM +0100, Oliver Graute wrote:
> This patch add c-ares to ptxdist, its a C library for async DNS requests
> 
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/c-ares.in   |    7 +++++++
>  rules/c-ares.make |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+)
>  create mode 100644 rules/c-ares.in
>  create mode 100644 rules/c-ares.make
> 
> diff --git a/rules/c-ares.in b/rules/c-ares.in
> new file mode 100644
> index 0000000..2443499
> --- /dev/null
> +++ b/rules/c-ares.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config C_ARES
> +	tristate
> +	prompt "c-ares"
> +	help
> +	  c-ares is a C library for asynchronous DNS requests (including name resolves)
> diff --git a/rules/c-ares.make b/rules/c-ares.make
> new file mode 100644
> index 0000000..e89b813
> --- /dev/null
> +++ b/rules/c-ares.make
> @@ -0,0 +1,52 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany, Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_C_ARES) += c-ares
> +
> +#
> +# Paths and names
> +#
> +C_ARES_VERSION	:= 1.10.0
> +C_ARES_MD5		:= 6d325e6ef7afbb0a1041a4d2b1266533

Hmm, that's not the checksum I get here.

> +C_ARES		:= c-ares-$(C_ARES_VERSION)
> +C_ARES_SUFFIX	:= tar.gz
> +C_ARES_URL		:= http://c-ares.haxx.se/download//$(C_ARES).$(C_ARES_SUFFIX)
> +C_ARES_SOURCE	:= $(SRCDIR)/$(C_ARES).$(C_ARES_SUFFIX)
> +C_ARES_DIR		:= $(BUILDDIR)/$(C_ARES)
> +C_ARES_LICENSE	:= MIT license

please align the ':=' (in the file not the patch)

> +

add:

+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+#
> +# autoconf
> +#
> +C_ARES_CONF_TOOL	:= autoconf

You need to specify the configure options:

C_ARES_CONF_OPT		:= \
	$(CROSS_AUTOCONF_USR) \
...

Disable all debugging, $(GLOBAL_LARGE_FILE_OPTION) for the largefile option
and --enable-nonblocking I guess?

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/c-ares.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, c-ares)
> +	@$(call install_fixup, c-ares,PRIORITY,optional)
> +	@$(call install_fixup, c-ares,SECTION,base)
> +	@$(call install_fixup, c-ares,AUTHOR,"<oliver.graute@neuhaus.de>")
> +	@$(call install_fixup, c-ares,DESCRIPTION,missing)
> +
> +	@$(call install_lib, c-ares, 0, 0, 0644, libcares)
> +
> +	@$(call install_finish, c-ares)
> +
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de