[ptxdist] [PATCH] added mosh package to ptxdist

[ptxdist] [PATCH] added mosh package to ptxdist

[Oliver Graute]

added a rule for mosh 

Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
---
 rules/mosh.in   |    7 ++++
 rules/mosh.make |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 109 insertions(+)
 create mode 100644 rules/mosh.in
 create mode 100644 rules/mosh.make

diff --git a/rules/mosh.in b/rules/mosh.in
new file mode 100644
index 0000000..1866a4d
--- /dev/null
+++ b/rules/mosh.in
@@ -0,0 +1,7 @@
+## SECTION=networking
+
+config MOSH
+	tristate
+	prompt "mosh"
+	help
+	  Remote terminal application that allows roaming, supports intermittent connectivity, and provides intelligent local echo and line editing of user keystrokes. Mosh is a replacement for SSH. It's more robust and responsive, especially over Wi-Fi, cellular, and long-distance links.
diff --git a/rules/mosh.make b/rules/mosh.make
new file mode 100644
index 0000000..afbc90f
--- /dev/null
+++ b/rules/mosh.make
@@ -0,0 +1,102 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_MOSH) += mosh
+
+#
+# Paths and names
+#
+MOSH_VERSION	:= 1.2.4
+MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
+MOSH		:= mosh-$(MOSH_VERSION)
+MOSH_SUFFIX	:= tar.gz
+MOSH_URL		:= https://mosh.mit.edu//$(MOSH).$(MOSH_SUFFIX)
+MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
+MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
+MOSH_LICENSE	:= unknown
+
+# ----------------------------------------------------------------------------
+# Get
+# ----------------------------------------------------------------------------
+
+#$(MOSH_SOURCE):
+#	@$(call targetinfo)
+#	@$(call get, MOSH)
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+#MOSH_CONF_ENV	:= $(CROSS_ENV)
+
+#
+# autoconf
+#
+MOSH_CONF_TOOL	:= autoconf
+#MOSH_CONF_OPT	:= $(CROSS_AUTOCONF_USR)
+
+#$(STATEDIR)/mosh.prepare:
+#	@$(call targetinfo)
+#	@$(call clean, $(MOSH_DIR)/config.cache)
+#	cd $(MOSH_DIR) && \
+#		$(MOSH_PATH) $(MOSH_ENV) \
+#		./configure $(MOSH_CONF_OPT)
+#	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Compile
+# ----------------------------------------------------------------------------
+
+#$(STATEDIR)/mosh.compile:
+#	@$(call targetinfo)
+#	@$(call world/compile, MOSH)
+#	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Install
+# ----------------------------------------------------------------------------
+
+#$(STATEDIR)/mosh.install:
+#	@$(call targetinfo)
+#	@$(call world/install, MOSH)
+#	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/mosh.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, mosh)
+	@$(call install_fixup, mosh,PRIORITY,optional)
+	@$(call install_fixup, mosh,SECTION,base)
+	@$(call install_fixup, mosh,AUTHOR,"<OGR@neuhaus.de>")
+	@$(call install_fixup, mosh,DESCRIPTION,missing)
+
+	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-server, /usr/bin/mosh-server)
+	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-client, /usr/bin/mosh-client)
+
+	@$(call install_finish, mosh)
+
+	@$(call touch)
+
+# ----------------------------------------------------------------------------
+# Clean
+# ----------------------------------------------------------------------------
+
+#$(STATEDIR)/mosh.clean:
+#	@$(call targetinfo)
+#	@$(call clean_pkg, MOSH)
+
+# vim: syntax=make
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] added mosh package to ptxdist

[Alexander Aring]

Hi,

I have also some rules for mosh, but I added IPv6 support on it (which
is available on the github master branch).
Nevertheless I have some issues with mosh and IPv6 and that was the
reason why I didn't send it mainline. I try to compare now my rule with
your rule.

On Tue, Feb 10, 2015 at 08:05:21AM +0100, Oliver Graute wrote:
> added a rule for mosh 
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/mosh.in   |    7 ++++
>  rules/mosh.make |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 109 insertions(+)
>  create mode 100644 rules/mosh.in
>  create mode 100644 rules/mosh.make
> 
> diff --git a/rules/mosh.in b/rules/mosh.in
> new file mode 100644
> index 0000000..1866a4d
> --- /dev/null
> +++ b/rules/mosh.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config MOSH
> +	tristate
> +	prompt "mosh"

In my rule file I have:

	select PROTOBUF
	select NCURSES
	select ZLIB
	select OPENSSL

Additional I detected (because installing the mosh perl script):

	select PERL
	select IO_SOCKET_IP_PERL
	select OPENSSH			if RUNTIME
	select OPENSSH_SSH		if RUNTIME
	select OPENSSH_SSHD		if RUNTIME

I think it's also possible to switch from ssh to dropbear. I don't know
if somebody of the mosh crew tested that.

> +	help
> +	  Remote terminal application that allows roaming, supports intermittent connectivity, and provides intelligent local echo and line editing of user keystrokes. Mosh is a replacement for SSH. It's more robust and responsive, especially over Wi-Fi, cellular, and long-distance links.

80 chars width per line.

> diff --git a/rules/mosh.make b/rules/mosh.make
> new file mode 100644
> index 0000000..afbc90f
> --- /dev/null
> +++ b/rules/mosh.make
> @@ -0,0 +1,102 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MOSH) += mosh
> +
> +#
> +# Paths and names
> +#
> +MOSH_VERSION	:= 1.2.4
> +MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
> +MOSH		:= mosh-$(MOSH_VERSION)
> +MOSH_SUFFIX	:= tar.gz
> +MOSH_URL		:= https://mosh.mit.edu//$(MOSH).$(MOSH_SUFFIX)

nitpicking: "//" -> '/'

> +MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
> +MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
> +MOSH_LICENSE	:= unknown

MOSH_LICENSE	:= GPLv3

> +
> +# ----------------------------------------------------------------------------
> +# Get
> +# ----------------------------------------------------------------------------
> +
> +#$(MOSH_SOURCE):
> +#	@$(call targetinfo)
> +#	@$(call get, MOSH)
> +

remove

> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#MOSH_CONF_ENV	:= $(CROSS_ENV)
> +

remove

> +#
> +# autoconf
> +#
> +MOSH_CONF_TOOL	:= autoconf

remove

> +#MOSH_CONF_OPT	:= $(CROSS_AUTOCONF_USR)
> +

#
# autoconf
#
MOSH_AUTOCONF	:= \
	$(CROSS_AUTOCONF_USR) \
	--enable-hardening \
	--enable-client \
	--enable-server \
	--disable-examples \
	--enable-ufw \
	--disable-completion \
	--without-utempter

> +#$(STATEDIR)/mosh.prepare:
> +#	@$(call targetinfo)
> +#	@$(call clean, $(MOSH_DIR)/config.cache)
> +#	cd $(MOSH_DIR) && \
> +#		$(MOSH_PATH) $(MOSH_ENV) \
> +#		./configure $(MOSH_CONF_OPT)
> +#	@$(call touch)
> +

remove

> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.compile:
> +#	@$(call targetinfo)
> +#	@$(call world/compile, MOSH)
> +#	@$(call touch)
> +

same

> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.install:
> +#	@$(call targetinfo)
> +#	@$(call world/install, MOSH)
> +#	@$(call touch)
> +

same

> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mosh.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mosh)
> +	@$(call install_fixup, mosh,PRIORITY,optional)
> +	@$(call install_fixup, mosh,SECTION,base)
> +	@$(call install_fixup, mosh,AUTHOR,"<OGR@neuhaus.de>")

Differs from copyright on the top, maybe this should be:
"oliver.graute@neuhaus.de".

> +	@$(call install_fixup, mosh,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-server, /usr/bin/mosh-server)
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-client, /usr/bin/mosh-client)

change to: (there is no need to add the $(MOSH_DIR) in src.)

@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh)
@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-client)
@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-server)

> +
> +	@$(call install_finish, mosh)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Clean
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.clean:
> +#	@$(call targetinfo)
> +#	@$(call clean_pkg, MOSH)
> +

remove

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] added mosh package to ptxdist

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 4986 bytes --]

On 02/10/2015 08:05 AM, Oliver Graute wrote:
> added a rule for mosh 
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/mosh.in   |    7 ++++
>  rules/mosh.make |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 109 insertions(+)
>  create mode 100644 rules/mosh.in
>  create mode 100644 rules/mosh.make
> 
> diff --git a/rules/mosh.in b/rules/mosh.in
> new file mode 100644
> index 0000000..1866a4d
> --- /dev/null
> +++ b/rules/mosh.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config MOSH
> +	tristate
> +	prompt "mosh"

I assume mosh depends on several external libs, like protobufs and libssl.

> +	help
> +	  Remote terminal application that allows roaming, supports intermittent connectivity, and provides intelligent local echo and line editing of user keystrokes. Mosh is a replacement for SSH. It's more robust and responsive, especially over Wi-Fi, cellular, and long-distance links.

Please limit to 72...80 chars per line.

> diff --git a/rules/mosh.make b/rules/mosh.make
> new file mode 100644
> index 0000000..afbc90f
> --- /dev/null
> +++ b/rules/mosh.make
> @@ -0,0 +1,102 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MOSH) += mosh
> +
> +#
> +# Paths and names
> +#
> +MOSH_VERSION	:= 1.2.4
> +MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
> +MOSH		:= mosh-$(MOSH_VERSION)
> +MOSH_SUFFIX	:= tar.gz
> +MOSH_URL		:= https://mosh.mit.edu//$(MOSH).$(MOSH_SUFFIX)
                                               ^^
please remove one /

> +MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
> +MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
> +MOSH_LICENSE	:= unknown

please add the license of mosh

> +
> +# ----------------------------------------------------------------------------
> +# Get
> +# ----------------------------------------------------------------------------
> +
> +#$(MOSH_SOURCE):
> +#	@$(call targetinfo)
> +#	@$(call get, MOSH)

please remove the commented out stages: get, most of prepare, compile,
install and clean.

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#MOSH_CONF_ENV	:= $(CROSS_ENV)
> +
> +#
> +# autoconf
> +#
> +MOSH_CONF_TOOL	:= autoconf
> +#MOSH_CONF_OPT	:= $(CROSS_AUTOCONF_USR)
> +
> +#$(STATEDIR)/mosh.prepare:
> +#	@$(call targetinfo)
> +#	@$(call clean, $(MOSH_DIR)/config.cache)
> +#	cd $(MOSH_DIR) && \
> +#		$(MOSH_PATH) $(MOSH_ENV) \
> +#		./configure $(MOSH_CONF_OPT)
> +#	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.compile:
> +#	@$(call targetinfo)
> +#	@$(call world/compile, MOSH)
> +#	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.install:
> +#	@$(call targetinfo)
> +#	@$(call world/install, MOSH)
> +#	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mosh.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mosh)
> +	@$(call install_fixup, mosh,PRIORITY,optional)
> +	@$(call install_fixup, mosh,SECTION,base)
> +	@$(call install_fixup, mosh,AUTHOR,"<OGR@neuhaus.de>")
> +	@$(call install_fixup, mosh,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-server, /usr/bin/mosh-server)
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-client, /usr/bin/mosh-client)
> +
> +	@$(call install_finish, mosh)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Clean
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.clean:
> +#	@$(call targetinfo)
> +#	@$(call clean_pkg, MOSH)
> +
> +# vim: syntax=make
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] added mosh package to ptxdist

[Alexander Aring]

Hi,

I missed something, please add also a name before your mail subject
like:

[PATCH] mosh: added mosh package to ptxdist

On Tue, Feb 10, 2015 at 08:53:18AM +0100, Alexander Aring wrote:
> Hi,
> 
> I have also some rules for mosh, but I added IPv6 support on it (which
> is available on the github master branch).
> Nevertheless I have some issues with mosh and IPv6 and that was the
> reason why I didn't send it mainline. I try to compare now my rule with
> your rule.
> 
> On Tue, Feb 10, 2015 at 08:05:21AM +0100, Oliver Graute wrote:
> > added a rule for mosh 
> > 
> > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > ---
> >  rules/mosh.in   |    7 ++++
> >  rules/mosh.make |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 109 insertions(+)
> >  create mode 100644 rules/mosh.in
> >  create mode 100644 rules/mosh.make
> > 
> > diff --git a/rules/mosh.in b/rules/mosh.in
> > new file mode 100644
> > index 0000000..1866a4d
> > --- /dev/null
> > +++ b/rules/mosh.in
> > @@ -0,0 +1,7 @@
> > +## SECTION=networking
> > +
> > +config MOSH
> > +	tristate
> > +	prompt "mosh"
> 
> In my rule file I have:
> 
> 	select PROTOBUF
> 	select NCURSES
> 	select ZLIB
> 	select OPENSSL
> 
> Additional I detected (because installing the mosh perl script):
> 
> 	select PERL
> 	select IO_SOCKET_IP_PERL

this should all if RUNTIME, because it's only necessary if you running
the mosh script at runtime.

If you don't want to install the mosh script, maybe we could add a own
config there. Something like "config MOSH_INSTALL_MOSH_SCRIPT".

> 	select OPENSSH			if RUNTIME
> 	select OPENSSH_SSH		if RUNTIME
> 	select OPENSSH_SSHD		if RUNTIME
> 

.....

> > +#MOSH_CONF_OPT	:= $(CROSS_AUTOCONF_USR)
> > +
> 
> #
> # autoconf
> #
> MOSH_AUTOCONF	:= \
> 	$(CROSS_AUTOCONF_USR) \
> 	--enable-hardening \
> 	--enable-client \
> 	--enable-server \
> 	--disable-examples \
> 	--enable-ufw \

the ufw is some ubuntu firewall helper thingy. Better to disable it
here. We don't have such fancy stuff. :-)

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Oliver Graute]

second try, thank you for feedback its my first contribution to ptxdist  

Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
---
 rules/mosh.in   |   17 ++++++++++++++++
 rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 78 insertions(+)
 create mode 100644 rules/mosh.in
 create mode 100644 rules/mosh.make

diff --git a/rules/mosh.in b/rules/mosh.in
new file mode 100644
index 0000000..d9cc583
--- /dev/null
+++ b/rules/mosh.in
@@ -0,0 +1,17 @@
+## SECTION=networking
+
+config MOSH
+	tristate
+	prompt "mosh"
+select PROTOBUF
+         select NCURSES
+         select ZLIB
+         select OPENSSL
+         select OPENSSH                      if RUNTIME
+         select OPENSSH_SSH              if RUNTIME
+         select OPENSSH_SSHD                 if RUNTIME
+	help
+	  Remote terminal application that allows roaming, supports intermittent
+	  connectivity, and provides intelligent local echo and line editing of
+ 	  user keystrokes. Mosh is a replacement for SSH. It's more robust and
+ 	  responsive, especially over Wi-Fi, cellular, and long-distance links.
diff --git a/rules/mosh.make b/rules/mosh.make
new file mode 100644
index 0000000..b96af5a
--- /dev/null
+++ b/rules/mosh.make
@@ -0,0 +1,61 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_MOSH) += mosh
+
+#
+# Paths and names
+#
+MOSH_VERSION	:= 1.2.4
+MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
+MOSH		:= mosh-$(MOSH_VERSION)
+MOSH_SUFFIX	:= tar.gz
+MOSH_URL		:= https://mosh.mit.edu/$(MOSH).$(MOSH_SUFFIX)
+MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
+MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
+MOSH_LICENSE	:= GPLv3
+
+#
+# autoconf
+#
+MOSH_AUTOCONF        := \
+         $(CROSS_AUTOCONF_USR) \
+         --enable-hardening \
+         --enable-client \
+         --enable-server \
+         --disable-examples \
+         --disable-completion \
+         --without-utempter
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/mosh.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, mosh)
+	@$(call install_fixup, mosh,PRIORITY,optional)
+	@$(call install_fixup, mosh,SECTION,base)
+	@$(call install_fixup, mosh,AUTHOR,"<Oliver Graute@neuhaus.de>")
+	@$(call install_fixup, mosh,DESCRIPTION,missing)
+
+	@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh)
+	@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-server)
+	@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-client)
+
+	@$(call install_finish, mosh)
+
+	@$(call touch)
+
+# vim: syntax=make
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Michael Olbrich]

On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> second try, thank you for feedback its my first contribution to ptxdist  

Thanks, I've applied it with some cleanups: Make sure you handle the
white-spaces correctly in future patches. And Alex got it wrong. It should
be:

MOSH_CONF_TOOL	:= autoconf
MOSH_CONF_OPT	:= \
[...]

Michael


> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/mosh.in   |   17 ++++++++++++++++
>  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 78 insertions(+)
>  create mode 100644 rules/mosh.in
>  create mode 100644 rules/mosh.make
> 
> diff --git a/rules/mosh.in b/rules/mosh.in
> new file mode 100644
> index 0000000..d9cc583
> --- /dev/null
> +++ b/rules/mosh.in
> @@ -0,0 +1,17 @@
> +## SECTION=networking
> +
> +config MOSH
> +	tristate
> +	prompt "mosh"
> +select PROTOBUF
> +         select NCURSES
> +         select ZLIB
> +         select OPENSSL
> +         select OPENSSH                      if RUNTIME
> +         select OPENSSH_SSH              if RUNTIME
> +         select OPENSSH_SSHD                 if RUNTIME
> +	help
> +	  Remote terminal application that allows roaming, supports intermittent
> +	  connectivity, and provides intelligent local echo and line editing of
> + 	  user keystrokes. Mosh is a replacement for SSH. It's more robust and
> + 	  responsive, especially over Wi-Fi, cellular, and long-distance links.
> diff --git a/rules/mosh.make b/rules/mosh.make
> new file mode 100644
> index 0000000..b96af5a
> --- /dev/null
> +++ b/rules/mosh.make
> @@ -0,0 +1,61 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MOSH) += mosh
> +
> +#
> +# Paths and names
> +#
> +MOSH_VERSION	:= 1.2.4
> +MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
> +MOSH		:= mosh-$(MOSH_VERSION)
> +MOSH_SUFFIX	:= tar.gz
> +MOSH_URL		:= https://mosh.mit.edu/$(MOSH).$(MOSH_SUFFIX)
> +MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
> +MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
> +MOSH_LICENSE	:= GPLv3
> +
> +#
> +# autoconf
> +#
> +MOSH_AUTOCONF        := \
> +         $(CROSS_AUTOCONF_USR) \
> +         --enable-hardening \
> +         --enable-client \
> +         --enable-server \
> +         --disable-examples \
> +         --disable-completion \
> +         --without-utempter
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mosh.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mosh)
> +	@$(call install_fixup, mosh,PRIORITY,optional)
> +	@$(call install_fixup, mosh,SECTION,base)
> +	@$(call install_fixup, mosh,AUTHOR,"<Oliver Graute@neuhaus.de>")
> +	@$(call install_fixup, mosh,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh)
> +	@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-server)
> +	@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-client)
> +
> +	@$(call install_finish, mosh)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Alexander Aring]

On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > second try, thank you for feedback its my first contribution to ptxdist  
> 
> Thanks, I've applied it with some cleanups: Make sure you handle the
> white-spaces correctly in future patches. And Alex got it wrong. It should
> be:
> 
> MOSH_CONF_TOOL	:= autoconf
> MOSH_CONF_OPT	:= \
> [...]
> 

ok. saved. :-)

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Alexander Aring]

On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > second try, thank you for feedback its my first contribution to ptxdist  
> 
> Thanks, I've applied it with some cleanups: Make sure you handle the
> white-spaces correctly in future patches. And Alex got it wrong. It should
> be:
> 
> MOSH_CONF_TOOL	:= autoconf
> MOSH_CONF_OPT	:= \
> [...]
> 
> Michael
> 
> 
> > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > ---
> >  rules/mosh.in   |   17 ++++++++++++++++
> >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 78 insertions(+)
> >  create mode 100644 rules/mosh.in
> >  create mode 100644 rules/mosh.make
> > 
> > diff --git a/rules/mosh.in b/rules/mosh.in
> > new file mode 100644
> > index 0000000..d9cc583
> > --- /dev/null
> > +++ b/rules/mosh.in
> > @@ -0,0 +1,17 @@
> > +## SECTION=networking
> > +
> > +config MOSH
> > +	tristate
> > +	prompt "mosh"
> > +select PROTOBUF
> > +         select NCURSES
> > +         select ZLIB
> > +         select OPENSSL
> > +         select OPENSSH                      if RUNTIME
> > +         select OPENSSH_SSH              if RUNTIME
> > +         select OPENSSH_SSHD                 if RUNTIME

now I see, there is PERL missing here.

The mosh script require PERL with:

select PERL if RUNTIME

also the mosh script uses:

use IO::Socket::INET;, see [0].

that means we need also a:

select IO_SOCKET_INET6_PERL if RUNTIME, see [1].

[0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
[1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Michael Olbrich]

On Mon, Feb 16, 2015 at 10:52:01AM +0100, Alexander Aring wrote:
> On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> > On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > > second try, thank you for feedback its my first contribution to ptxdist  
> > 
> > Thanks, I've applied it with some cleanups: Make sure you handle the
> > white-spaces correctly in future patches. And Alex got it wrong. It should
> > be:
> > 
> > MOSH_CONF_TOOL	:= autoconf
> > MOSH_CONF_OPT	:= \
> > [...]
> > 
> > Michael
> > 
> > 
> > > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > > ---
> > >  rules/mosh.in   |   17 ++++++++++++++++
> > >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 78 insertions(+)
> > >  create mode 100644 rules/mosh.in
> > >  create mode 100644 rules/mosh.make
> > > 
> > > diff --git a/rules/mosh.in b/rules/mosh.in
> > > new file mode 100644
> > > index 0000000..d9cc583
> > > --- /dev/null
> > > +++ b/rules/mosh.in
> > > @@ -0,0 +1,17 @@
> > > +## SECTION=networking
> > > +
> > > +config MOSH
> > > +	tristate
> > > +	prompt "mosh"
> > > +select PROTOBUF
> > > +         select NCURSES
> > > +         select ZLIB
> > > +         select OPENSSL
> > > +         select OPENSSH                      if RUNTIME
> > > +         select OPENSSH_SSH              if RUNTIME
> > > +         select OPENSSH_SSHD                 if RUNTIME
> 
> now I see, there is PERL missing here.
> 
> The mosh script require PERL with:
> 
> select PERL if RUNTIME
> 
> also the mosh script uses:
> 
> use IO::Socket::INET;, see [0].
> 
> that means we need also a:
> 
> select IO_SOCKET_INET6_PERL if RUNTIME, see [1].
> 
> [0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
> [1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm

Is it usefull without perl? Maybe the server could be startet without it?
The we should add an option for this.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Alexander Aring]

On Mon, Feb 16, 2015 at 11:38:40AM +0100, Michael Olbrich wrote:
> On Mon, Feb 16, 2015 at 10:52:01AM +0100, Alexander Aring wrote:
> > On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> > > On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > > > second try, thank you for feedback its my first contribution to ptxdist  
> > > 
> > > Thanks, I've applied it with some cleanups: Make sure you handle the
> > > white-spaces correctly in future patches. And Alex got it wrong. It should
> > > be:
> > > 
> > > MOSH_CONF_TOOL	:= autoconf
> > > MOSH_CONF_OPT	:= \
> > > [...]
> > > 
> > > Michael
> > > 
> > > 
> > > > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > > > ---
> > > >  rules/mosh.in   |   17 ++++++++++++++++
> > > >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 78 insertions(+)
> > > >  create mode 100644 rules/mosh.in
> > > >  create mode 100644 rules/mosh.make
> > > > 
> > > > diff --git a/rules/mosh.in b/rules/mosh.in
> > > > new file mode 100644
> > > > index 0000000..d9cc583
> > > > --- /dev/null
> > > > +++ b/rules/mosh.in
> > > > @@ -0,0 +1,17 @@
> > > > +## SECTION=networking
> > > > +
> > > > +config MOSH
> > > > +	tristate
> > > > +	prompt "mosh"
> > > > +select PROTOBUF
> > > > +         select NCURSES
> > > > +         select ZLIB
> > > > +         select OPENSSL
> > > > +         select OPENSSH                      if RUNTIME
> > > > +         select OPENSSH_SSH              if RUNTIME
> > > > +         select OPENSSH_SSHD                 if RUNTIME
> > 
> > now I see, there is PERL missing here.
> > 
> > The mosh script require PERL with:
> > 
> > select PERL if RUNTIME
> > 
> > also the mosh script uses:
> > 
> > use IO::Socket::INET;, see [0].
> > 
> > that means we need also a:
> > 
> > select IO_SOCKET_INET6_PERL if RUNTIME, see [1].
> > 
> > [0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
> > [1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm
> 
> Is it usefull without perl? Maybe the server could be startet without it?
> The we should add an option for this.
> 

yep, option would be great.

For myself I don't know how to create a mosh connection without the mosh
script (this is only possible if you do some own hard work). On
website stands:

---

The mosh command is a wrapper script that is designed to be the primary way
that you use mosh. In most cases, you can simply just replace "ssh" with
"mosh" in your command line. Behind the scenes, the mosh wrapper script
will SSH to the server, start up mosh-server, and then close the SSH
connection. Then it will start up the mosh-client executable on the client,
passing it the necessary information for it to connect to the newly spawned
mosh-server instance.

In normal usage, mosh-client and mosh-server don't need to be run directly.

---

Afterwards there is a complicated How-To how you setup a connection
without mosh script. See [0], "Q: How do I run the mosh client and
server separately?".

I am fine to add a option and we have already a perfect help message see
above.

I also mentioned to add a config for the mosh script in some of my
previous mail. [1] 'Something like "config MOSH_INSTALL_MOSH_SCRIPT"'.


btw: another issue is maybe the OPENSSH_SSH and OPENSSH_SSHD, if you
want only be a server or a client. This "could" be an option which
select OPENSSH_SSH or OPENSSH_SSHD when client or server only, but I
would keep it in this way. Otherwise it would be much complicated to
deal with the dependencies.

- Alex

[0] https://mosh.mit.edu/
[1] http://article.gmane.org/gmane.comp.embedded.ptxdist.devel/12592

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Michael Olbrich]

On Mon, Feb 16, 2015 at 11:55:51AM +0100, Alexander Aring wrote:
> On Mon, Feb 16, 2015 at 11:38:40AM +0100, Michael Olbrich wrote:
> > On Mon, Feb 16, 2015 at 10:52:01AM +0100, Alexander Aring wrote:
> > > On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> > > > On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > > > > second try, thank you for feedback its my first contribution to ptxdist  
> > > > 
> > > > Thanks, I've applied it with some cleanups: Make sure you handle the
> > > > white-spaces correctly in future patches. And Alex got it wrong. It should
> > > > be:
> > > > 
> > > > MOSH_CONF_TOOL	:= autoconf
> > > > MOSH_CONF_OPT	:= \
> > > > [...]
> > > > 
> > > > Michael
> > > > 
> > > > 
> > > > > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > > > > ---
> > > > >  rules/mosh.in   |   17 ++++++++++++++++
> > > > >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > >  2 files changed, 78 insertions(+)
> > > > >  create mode 100644 rules/mosh.in
> > > > >  create mode 100644 rules/mosh.make
> > > > > 
> > > > > diff --git a/rules/mosh.in b/rules/mosh.in
> > > > > new file mode 100644
> > > > > index 0000000..d9cc583
> > > > > --- /dev/null
> > > > > +++ b/rules/mosh.in
> > > > > @@ -0,0 +1,17 @@
> > > > > +## SECTION=networking
> > > > > +
> > > > > +config MOSH
> > > > > +	tristate
> > > > > +	prompt "mosh"
> > > > > +select PROTOBUF
> > > > > +         select NCURSES
> > > > > +         select ZLIB
> > > > > +         select OPENSSL
> > > > > +         select OPENSSH                      if RUNTIME
> > > > > +         select OPENSSH_SSH              if RUNTIME
> > > > > +         select OPENSSH_SSHD                 if RUNTIME
> > > 
> > > now I see, there is PERL missing here.
> > > 
> > > The mosh script require PERL with:
> > > 
> > > select PERL if RUNTIME
> > > 
> > > also the mosh script uses:
> > > 
> > > use IO::Socket::INET;, see [0].
> > > 
> > > that means we need also a:
> > > 
> > > select IO_SOCKET_INET6_PERL if RUNTIME, see [1].
> > > 
> > > [0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
> > > [1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm
> > 
> > Is it usefull without perl? Maybe the server could be startet without it?
> > The we should add an option for this.
> > 
> 
> yep, option would be great.
> 
> For myself I don't know how to create a mosh connection without the mosh
> script (this is only possible if you do some own hard work). On
> website stands:
> 
> ---
> 
> The mosh command is a wrapper script that is designed to be the primary way
> that you use mosh. In most cases, you can simply just replace "ssh" with
> "mosh" in your command line. Behind the scenes, the mosh wrapper script
> will SSH to the server, start up mosh-server, and then close the SSH
> connection. Then it will start up the mosh-client executable on the client,
> passing it the necessary information for it to connect to the newly spawned
> mosh-server instance.
> 
> In normal usage, mosh-client and mosh-server don't need to be run directly.
> 
> ---
> 
> Afterwards there is a complicated How-To how you setup a connection
> without mosh script. See [0], "Q: How do I run the mosh client and
> server separately?".
> 
> I am fine to add a option and we have already a perfect help message see
> above.

ok.

> I also mentioned to add a config for the mosh script in some of my
> previous mail. [1] 'Something like "config MOSH_INSTALL_MOSH_SCRIPT"'.
> 
> 
> btw: another issue is maybe the OPENSSH_SSH and OPENSSH_SSHD, if you
> want only be a server or a client. This "could" be an option which
> select OPENSSH_SSH or OPENSSH_SSHD when client or server only, but I
> would keep it in this way. Otherwise it would be much complicated to
> deal with the dependencies.

I agree. If we need the option later, then we can still add it.

Michael

> - Alex
> 
> [0] https://mosh.mit.edu/
> [1] http://article.gmane.org/gmane.comp.embedded.ptxdist.devel/12592

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Alexander Aring]

On Mon, Feb 16, 2015 at 11:55:48AM +0100, Alexander Aring wrote:
...
> 
> I also mentioned to add a config for the mosh script in some of my
> previous mail. [1] 'Something like "config MOSH_INSTALL_MOSH_SCRIPT"'.
> 

There is a mistake in my previous mail it's IO_SOCKET_INET6_PERL not
IO_SOCKET_IP_PERL. They changed it for IPv6 functionality which I
tried to get working. This rule is also not mainline, it's inside my
private working BSP. Sorry! :-)


btw:
For the issue with IPv6 support, I think I have some missing dependency
which I don't know. It works on client (ptxdist) and server (arch-linux)
doesn't depend if 6LoWPAN connection or Ethernet IPv6.

The server simple doesn't work on ptxdist and I had no time now to debug
the issue. I also need to hard set "LANG=en_US.UTF-8" before running
mosh otherwise the application will not start. But this is a common
issue and all other people get it working by setting "LANG=en_US.UTF-8".

I need to look into that how ptxdist can deal with that.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de