Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Feb 16, 2015 at 11:55:51AM +0100, Alexander Aring wrote:
> On Mon, Feb 16, 2015 at 11:38:40AM +0100, Michael Olbrich wrote:
> > On Mon, Feb 16, 2015 at 10:52:01AM +0100, Alexander Aring wrote:
> > > On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> > > > On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > > > > second try, thank you for feedback its my first contribution to ptxdist  
> > > > 
> > > > Thanks, I've applied it with some cleanups: Make sure you handle the
> > > > white-spaces correctly in future patches. And Alex got it wrong. It should
> > > > be:
> > > > 
> > > > MOSH_CONF_TOOL	:= autoconf
> > > > MOSH_CONF_OPT	:= \
> > > > [...]
> > > > 
> > > > Michael
> > > > 
> > > > 
> > > > > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > > > > ---
> > > > >  rules/mosh.in   |   17 ++++++++++++++++
> > > > >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > >  2 files changed, 78 insertions(+)
> > > > >  create mode 100644 rules/mosh.in
> > > > >  create mode 100644 rules/mosh.make
> > > > > 
> > > > > diff --git a/rules/mosh.in b/rules/mosh.in
> > > > > new file mode 100644
> > > > > index 0000000..d9cc583
> > > > > --- /dev/null
> > > > > +++ b/rules/mosh.in
> > > > > @@ -0,0 +1,17 @@
> > > > > +## SECTION=networking
> > > > > +
> > > > > +config MOSH
> > > > > +	tristate
> > > > > +	prompt "mosh"
> > > > > +select PROTOBUF
> > > > > +         select NCURSES
> > > > > +         select ZLIB
> > > > > +         select OPENSSL
> > > > > +         select OPENSSH                      if RUNTIME
> > > > > +         select OPENSSH_SSH              if RUNTIME
> > > > > +         select OPENSSH_SSHD                 if RUNTIME
> > > 
> > > now I see, there is PERL missing here.
> > > 
> > > The mosh script require PERL with:
> > > 
> > > select PERL if RUNTIME
> > > 
> > > also the mosh script uses:
> > > 
> > > use IO::Socket::INET;, see [0].
> > > 
> > > that means we need also a:
> > > 
> > > select IO_SOCKET_INET6_PERL if RUNTIME, see [1].
> > > 
> > > [0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
> > > [1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm
> > 
> > Is it usefull without perl? Maybe the server could be startet without it?
> > The we should add an option for this.
> > 
> 
> yep, option would be great.
> 
> For myself I don't know how to create a mosh connection without the mosh
> script (this is only possible if you do some own hard work). On
> website stands:
> 
> ---
> 
> The mosh command is a wrapper script that is designed to be the primary way
> that you use mosh. In most cases, you can simply just replace "ssh" with
> "mosh" in your command line. Behind the scenes, the mosh wrapper script
> will SSH to the server, start up mosh-server, and then close the SSH
> connection. Then it will start up the mosh-client executable on the client,
> passing it the necessary information for it to connect to the newly spawned
> mosh-server instance.
> 
> In normal usage, mosh-client and mosh-server don't need to be run directly.
> 
> ---
> 
> Afterwards there is a complicated How-To how you setup a connection
> without mosh script. See [0], "Q: How do I run the mosh client and
> server separately?".
> 
> I am fine to add a option and we have already a perfect help message see
> above.

ok.

> I also mentioned to add a config for the mosh script in some of my
> previous mail. [1] 'Something like "config MOSH_INSTALL_MOSH_SCRIPT"'.
> 
> 
> btw: another issue is maybe the OPENSSH_SSH and OPENSSH_SSHD, if you
> want only be a server or a client. This "could" be an option which
> select OPENSSH_SSH or OPENSSH_SSHD when client or server only, but I
> would keep it in this way. Otherwise it would be much complicated to
> deal with the dependencies.

I agree. If we need the option later, then we can still add it.

Michael

> - Alex
> 
> [0] https://mosh.mit.edu/
> [1] http://article.gmane.org/gmane.comp.embedded.ptxdist.devel/12592

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de