From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1YNJ4a-0001wc-G6 for ptxdist@pengutronix.de; Mon, 16 Feb 2015 11:38:40 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1YNJ4a-00081j-ET for ptxdist@pengutronix.de; Mon, 16 Feb 2015 11:38:40 +0100 Date: Mon, 16 Feb 2015 11:38:40 +0100 From: Michael Olbrich Message-ID: <20150216103840.GA30223@pengutronix.de> References: <1423551921-29670-1-git-send-email-oliver.graute@neuhaus.de> <1423557877-32478-1-git-send-email-oliver.graute@neuhaus.de> <20150216093934.GC7021@pengutronix.de> <20150216095159.GC8708@omega> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150216095159.GC8708@omega> Subject: Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mon, Feb 16, 2015 at 10:52:01AM +0100, Alexander Aring wrote: > On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote: > > On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote: > > > second try, thank you for feedback its my first contribution to ptxdist > > > > Thanks, I've applied it with some cleanups: Make sure you handle the > > white-spaces correctly in future patches. And Alex got it wrong. It should > > be: > > > > MOSH_CONF_TOOL := autoconf > > MOSH_CONF_OPT := \ > > [...] > > > > Michael > > > > > > > Signed-off-by: Oliver Graute > > > --- > > > rules/mosh.in | 17 ++++++++++++++++ > > > rules/mosh.make | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 78 insertions(+) > > > create mode 100644 rules/mosh.in > > > create mode 100644 rules/mosh.make > > > > > > diff --git a/rules/mosh.in b/rules/mosh.in > > > new file mode 100644 > > > index 0000000..d9cc583 > > > --- /dev/null > > > +++ b/rules/mosh.in > > > @@ -0,0 +1,17 @@ > > > +## SECTION=networking > > > + > > > +config MOSH > > > + tristate > > > + prompt "mosh" > > > +select PROTOBUF > > > + select NCURSES > > > + select ZLIB > > > + select OPENSSL > > > + select OPENSSH if RUNTIME > > > + select OPENSSH_SSH if RUNTIME > > > + select OPENSSH_SSHD if RUNTIME > > now I see, there is PERL missing here. > > The mosh script require PERL with: > > select PERL if RUNTIME > > also the mosh script uses: > > use IO::Socket::INET;, see [0]. > > that means we need also a: > > select IO_SOCKET_INET6_PERL if RUNTIME, see [1]. > > [0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153 > [1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm Is it usefull without perl? Maybe the server could be startet without it? The we should add an option for this. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de