From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <alex.aring@gmail.com>) id 1YNILa-0006sW-N1
	for ptxdist@pengutronix.de; Mon, 16 Feb 2015 10:52:11 +0100
Received: by mail-wg0-f42.google.com with SMTP id n12so11693504wgh.1
	for <ptxdist@pengutronix.de>; Mon, 16 Feb 2015 01:52:04 -0800 (PST)
Received: from omega (p20030064A9217A2BE2CB4EFFFE1BB546.dip0.t-ipconnect.de.
	[2003:64:a921:7a2b:e2cb:4eff:fe1b:b546])
	by mx.google.com with ESMTPSA id nb9sm9212992wic.3.2015.02.16.01.52.03
	for <ptxdist@pengutronix.de>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Mon, 16 Feb 2015 01:52:03 -0800 (PST)
Date: Mon, 16 Feb 2015 10:52:01 +0100
From: Alexander Aring <alex.aring@gmail.com>
Message-ID: <20150216095159.GC8708@omega>
References: <1423551921-29670-1-git-send-email-oliver.graute@neuhaus.de>
	<1423557877-32478-1-git-send-email-oliver.graute@neuhaus.de>
	<20150216093934.GC7021@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20150216093934.GC7021@pengutronix.de>
Subject: Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > second try, thank you for feedback its my first contribution to ptxdist  
> 
> Thanks, I've applied it with some cleanups: Make sure you handle the
> white-spaces correctly in future patches. And Alex got it wrong. It should
> be:
> 
> MOSH_CONF_TOOL	:= autoconf
> MOSH_CONF_OPT	:= \
> [...]
> 
> Michael
> 
> 
> > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > ---
> >  rules/mosh.in   |   17 ++++++++++++++++
> >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 78 insertions(+)
> >  create mode 100644 rules/mosh.in
> >  create mode 100644 rules/mosh.make
> > 
> > diff --git a/rules/mosh.in b/rules/mosh.in
> > new file mode 100644
> > index 0000000..d9cc583
> > --- /dev/null
> > +++ b/rules/mosh.in
> > @@ -0,0 +1,17 @@
> > +## SECTION=networking
> > +
> > +config MOSH
> > +	tristate
> > +	prompt "mosh"
> > +select PROTOBUF
> > +         select NCURSES
> > +         select ZLIB
> > +         select OPENSSL
> > +         select OPENSSH                      if RUNTIME
> > +         select OPENSSH_SSH              if RUNTIME
> > +         select OPENSSH_SSHD                 if RUNTIME

now I see, there is PERL missing here.

The mosh script require PERL with:

select PERL if RUNTIME

also the mosh script uses:

use IO::Socket::INET;, see [0].

that means we need also a:

select IO_SOCKET_INET6_PERL if RUNTIME, see [1].

[0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
[1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de