Re: [ptxdist] [PATCHv2] mosh: added mosh package to ptxdist

[Alexander Aring <alex.aring@gmail.com>]

On Mon, Feb 16, 2015 at 10:39:34AM +0100, Michael Olbrich wrote:
> On Tue, Feb 10, 2015 at 09:44:37AM +0100, Oliver Graute wrote:
> > second try, thank you for feedback its my first contribution to ptxdist  
> 
> Thanks, I've applied it with some cleanups: Make sure you handle the
> white-spaces correctly in future patches. And Alex got it wrong. It should
> be:
> 
> MOSH_CONF_TOOL	:= autoconf
> MOSH_CONF_OPT	:= \
> [...]
> 
> Michael
> 
> 
> > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > ---
> >  rules/mosh.in   |   17 ++++++++++++++++
> >  rules/mosh.make |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 78 insertions(+)
> >  create mode 100644 rules/mosh.in
> >  create mode 100644 rules/mosh.make
> > 
> > diff --git a/rules/mosh.in b/rules/mosh.in
> > new file mode 100644
> > index 0000000..d9cc583
> > --- /dev/null
> > +++ b/rules/mosh.in
> > @@ -0,0 +1,17 @@
> > +## SECTION=networking
> > +
> > +config MOSH
> > +	tristate
> > +	prompt "mosh"
> > +select PROTOBUF
> > +         select NCURSES
> > +         select ZLIB
> > +         select OPENSSL
> > +         select OPENSSH                      if RUNTIME
> > +         select OPENSSH_SSH              if RUNTIME
> > +         select OPENSSH_SSHD                 if RUNTIME

now I see, there is PERL missing here.

The mosh script require PERL with:

select PERL if RUNTIME

also the mosh script uses:

use IO::Socket::INET;, see [0].

that means we need also a:

select IO_SOCKET_INET6_PERL if RUNTIME, see [1].

[0] https://github.com/keithw/mosh/blob/mosh-1.2.4/scripts/mosh#L153
[1] http://search.cpan.org/~shlomif/IO-Socket-INET6-2.72/lib/IO/Socket/INET6.pm

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de