Re: [ptxdist] [PATCH] added mosh package to ptxdist

[Alexander Aring <alex.aring@gmail.com>]

Hi,

I have also some rules for mosh, but I added IPv6 support on it (which
is available on the github master branch).
Nevertheless I have some issues with mosh and IPv6 and that was the
reason why I didn't send it mainline. I try to compare now my rule with
your rule.

On Tue, Feb 10, 2015 at 08:05:21AM +0100, Oliver Graute wrote:
> added a rule for mosh 
> 
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
>  rules/mosh.in   |    7 ++++
>  rules/mosh.make |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 109 insertions(+)
>  create mode 100644 rules/mosh.in
>  create mode 100644 rules/mosh.make
> 
> diff --git a/rules/mosh.in b/rules/mosh.in
> new file mode 100644
> index 0000000..1866a4d
> --- /dev/null
> +++ b/rules/mosh.in
> @@ -0,0 +1,7 @@
> +## SECTION=networking
> +
> +config MOSH
> +	tristate
> +	prompt "mosh"

In my rule file I have:

	select PROTOBUF
	select NCURSES
	select ZLIB
	select OPENSSL

Additional I detected (because installing the mosh perl script):

	select PERL
	select IO_SOCKET_IP_PERL
	select OPENSSH			if RUNTIME
	select OPENSSH_SSH		if RUNTIME
	select OPENSSH_SSHD		if RUNTIME

I think it's also possible to switch from ssh to dropbear. I don't know
if somebody of the mosh crew tested that.

> +	help
> +	  Remote terminal application that allows roaming, supports intermittent connectivity, and provides intelligent local echo and line editing of user keystrokes. Mosh is a replacement for SSH. It's more robust and responsive, especially over Wi-Fi, cellular, and long-distance links.

80 chars width per line.

> diff --git a/rules/mosh.make b/rules/mosh.make
> new file mode 100644
> index 0000000..afbc90f
> --- /dev/null
> +++ b/rules/mosh.make
> @@ -0,0 +1,102 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 Dr. Neuhaus Telekommunikation GmbH, Hamburg Germany,  Oliver Graute <oliver.graute@neuhaus.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_MOSH) += mosh
> +
> +#
> +# Paths and names
> +#
> +MOSH_VERSION	:= 1.2.4
> +MOSH_MD5		:= c2d918f4d91fdc32546e2e089f9281b2
> +MOSH		:= mosh-$(MOSH_VERSION)
> +MOSH_SUFFIX	:= tar.gz
> +MOSH_URL		:= https://mosh.mit.edu//$(MOSH).$(MOSH_SUFFIX)

nitpicking: "//" -> '/'

> +MOSH_SOURCE	:= $(SRCDIR)/$(MOSH).$(MOSH_SUFFIX)
> +MOSH_DIR		:= $(BUILDDIR)/$(MOSH)
> +MOSH_LICENSE	:= unknown

MOSH_LICENSE	:= GPLv3

> +
> +# ----------------------------------------------------------------------------
> +# Get
> +# ----------------------------------------------------------------------------
> +
> +#$(MOSH_SOURCE):
> +#	@$(call targetinfo)
> +#	@$(call get, MOSH)
> +

remove

> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#MOSH_CONF_ENV	:= $(CROSS_ENV)
> +

remove

> +#
> +# autoconf
> +#
> +MOSH_CONF_TOOL	:= autoconf

remove

> +#MOSH_CONF_OPT	:= $(CROSS_AUTOCONF_USR)
> +

#
# autoconf
#
MOSH_AUTOCONF	:= \
	$(CROSS_AUTOCONF_USR) \
	--enable-hardening \
	--enable-client \
	--enable-server \
	--disable-examples \
	--enable-ufw \
	--disable-completion \
	--without-utempter

> +#$(STATEDIR)/mosh.prepare:
> +#	@$(call targetinfo)
> +#	@$(call clean, $(MOSH_DIR)/config.cache)
> +#	cd $(MOSH_DIR) && \
> +#		$(MOSH_PATH) $(MOSH_ENV) \
> +#		./configure $(MOSH_CONF_OPT)
> +#	@$(call touch)
> +

remove

> +# ----------------------------------------------------------------------------
> +# Compile
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.compile:
> +#	@$(call targetinfo)
> +#	@$(call world/compile, MOSH)
> +#	@$(call touch)
> +

same

> +# ----------------------------------------------------------------------------
> +# Install
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.install:
> +#	@$(call targetinfo)
> +#	@$(call world/install, MOSH)
> +#	@$(call touch)
> +

same

> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/mosh.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, mosh)
> +	@$(call install_fixup, mosh,PRIORITY,optional)
> +	@$(call install_fixup, mosh,SECTION,base)
> +	@$(call install_fixup, mosh,AUTHOR,"<OGR@neuhaus.de>")

Differs from copyright on the top, maybe this should be:
"oliver.graute@neuhaus.de".

> +	@$(call install_fixup, mosh,DESCRIPTION,missing)
> +
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-server, /usr/bin/mosh-server)
> +	@$(call install_copy, mosh, 0, 0, 0755, $(MOSH_DIR)/src/frontend/mosh-client, /usr/bin/mosh-client)

change to: (there is no need to add the $(MOSH_DIR) in src.)

@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh)
@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-client)
@$(call install_copy, mosh, 0, 0, 0755, -, /usr/bin/mosh-server)

> +
> +	@$(call install_finish, mosh)
> +
> +	@$(call touch)
> +
> +# ----------------------------------------------------------------------------
> +# Clean
> +# ----------------------------------------------------------------------------
> +
> +#$(STATEDIR)/mosh.clean:
> +#	@$(call targetinfo)
> +#	@$(call clean_pkg, MOSH)
> +

remove

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de