Re: [ptxdist] [PATCHv2 4/4] openvpn: rework and version bump

[Alexander Aring <alex.aring@gmail.com>]

On Mon, Jan 26, 2015 at 04:24:10PM +0100, Michael Olbrich wrote:
> On Sun, Jan 25, 2015 at 08:56:24PM +0100, Alexander Aring wrote:
> > This patch reworks the openvpn rules. Some points which are new now:
> > 
> > - systemd support if OPENVPN_SYSTEMD
> > - install openvpn sample configs as reference for /etc/openvpn/
> > - install openvpn sample scripts (ethernet bridging)
> > - add required environemnt for networking utilities while configure
> > - add several missed autoconf configure options
> > 
> > Additional this patch do a version bump to 2.3.6
> > 
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  rules/openvpn.in   | 27 +++++++++++++++++++++++++
> >  rules/openvpn.make | 59 +++++++++++++++++++++++++++++++++++++++++++-----------
> >  2 files changed, 74 insertions(+), 12 deletions(-)
> > 
> > diff --git a/rules/openvpn.in b/rules/openvpn.in
> > index 3649968..1cd4a54 100644
> > --- a/rules/openvpn.in
> > +++ b/rules/openvpn.in
> > @@ -5,6 +5,11 @@ menuconfig OPENVPN
> >  	prompt "openvpn                       "
> >  	select OPENSSL
> >  	select LIBLZO if OPENVPN_LZO
> > +	select IPROUTE2		if !BUSYBOX_IP && RUNTIME
> > +	select IPROUTE2_IP	if !BUSYBOX_IP && RUNTIME
> > +	select BUSYBOX_IFCONFIG
> > +	select BUSYBOX_NETSTAT
> > +	select BUSYBOX_ROUTE
> >  	help
> >  	  virtual private network daemon
> >  
> > @@ -34,4 +39,26 @@ config OPENVPN_LZO
> >  	  will select the LZO library as well.
> >  	  If unsure, say N.
> >  
> > +config OPENVPN_SYSTEMD
> > +	bool
> > +	prompt "Enable systemd support"
> > +	depends on SYSTEMD
> 
> This does not work. We need a build-time dependency.
> 
> add
> 
> 	select SYSTEMD		if OPENVPN_SYSTEMD
> 
> above instead.
> 

ok.

> Michael
> 
> > +	help
> > +	  This enables systemd support for openvpn.
> > +
> > +config OPENVPN_INSTALL_SAMPLE_CONFIGS
> > +	bool
> > +	prompt "Install sample configs"
> > +	select IPTABLES
> > +	select IPTABLES_INSTALL_TOOLS
> 
> mot this to the main option with 'if OPENVPN_INSTALL_SAMPLE_CONFIGS && RUNTIME'
> 
> > +	help
> > +	  Install sample configs into /usr/share/openvpn/sample-config-files.
> > +
> > +config OPENVPN_INSTALL_SAMPLE_SCRIPTS
> > +	bool
> > +	prompt "Install sample scripts"
> > +	select BRIDGE_UTILS
> 
> The same here.
> 

ok.

-- 
ptxdist mailing list
ptxdist@pengutronix.de