Re: [ptxdist] [PATCH 06/10] collectd: add base functionality

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

> > This is just a copy from the shipped file, right? Just install it manually
> > in the install stage and then use install_copy in targetinstall.
> 
> It's modified to use the standard location for the config file.

In that case, we should clean it up:

On Tue, Jan 27, 2015 at 11:01:59AM +0100, Robert Schwebel wrote:
> On Tue, Jan 27, 2015 at 08:31:42AM +0100, Michael Olbrich wrote:
> > > diff --git a/generic/lib/systemd/system/collectd.service b/generic/lib/systemd/system/collectd.service
> > > new file mode 100644
> > > index 0000000..53eb5db
> > > --- /dev/null
> > > +++ b/generic/lib/systemd/system/collectd.service
> > > @@ -0,0 +1,15 @@
> > > +[Unit]
> > > +Description=statistics collection daemon
> > > +Documentation=man:collectd(1)
> > > +After=local-fs.target network.target
> > > +Requires=local-fs.target network.target

local-fs.target is already the default, so that can be dropped.
network.target is rarely what you want. What kind of network requirements
does collectd have?

> > > +
> > > +[Service]
> > > +ExecStart=/usr/sbin/collectd -C /etc/collectd.conf -f

drop the config file, it it's the default.

> > > +Restart=always

> > > +RestartSec=10

I don't see a reason to wait 10 seconds. The default should be ok.

> > > +StandardOutput=syslog
> > > +StandardError=syslog

syslog will just be forwarded to the journal, so this can be dropped.

Michael

> > > +
> > > +[Install]
> > > +WantedBy=multi-user.target
> > 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de