From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1YG10m-000273-Bz for ptxdist@pengutronix.de; Tue, 27 Jan 2015 08:56:36 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1YG10m-0005PM-A3 for ptxdist@pengutronix.de; Tue, 27 Jan 2015 08:56:36 +0100 Date: Tue, 27 Jan 2015 08:56:36 +0100 From: Michael Olbrich Message-ID: <20150127075636.GD5565@pengutronix.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] ptxdist: BUSYBOX_NTPD blocks NTP Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mon, Jan 26, 2015 at 05:24:55PM +0100, Guillermo Rodriguez Garcia wrote: > Hello all, > > I am using the ntpd applet in busybox but also wanted to enable the ntpdate > program (yes I know use of ntpdate is not recommended in general but this > is for a very specific use case). However I see that ntpdate is part of the > "ntp" package and that the ntp package is blocked by BUSYBOX_NTPD. From > rules/ntp.in: > > menuconfig NTP > tristate > prompt "ntp " > select OPENSSL if NTP_CRYPTO > select ROOTFS_VAR_CACHE if NTP_NTPD > select LIBC_M > select LIBC_RT > select GCCLIBS_GCC_S > select LIBMD > depends on !BUSYBOX_NTPD || ALLYES > > [...] > config NTP_NTPDATE > bool > prompt "install ntpdate" > depends on NTP > > > Obviously one would not want to run two ntp services at the same time, but > since busybox lacks an ntpdate command, there are cases where one would > want to use ntpdate from the NTP package while still using Busybox's ntpd > for everything else. > > My question is: Is there any reason why this wouldn't work? Was the > "depends on !BUSYBOX_NTPD" line added just to avoid the possibility of the > two ntp services running at the same time? Or is it there to guard from > other possible problems/issues? We usually add those lines only to prevent two packages from installing the same file. In this case we have the !BUSYBOX_NTPD check twice, once for the package and once for ntpd. This is clearly wrong. I don't see a reason why the check for the packages is needed and I don't remember why I added it. I suggest you remove the check (and the comment at the end of the file) and see what happens. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de