From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <alex.aring@gmail.com>) id 1YCupS-0007F4-KK
	for ptxdist@pengutronix.de; Sun, 18 Jan 2015 19:44:06 +0100
Received: by mail-wi0-f174.google.com with SMTP id n3so11259385wiv.1
	for <ptxdist@pengutronix.de>; Sun, 18 Jan 2015 10:44:00 -0800 (PST)
Received: from omega (p20030064A919CE0DE2CB4EFFFE1BB546.dip0.t-ipconnect.de.
	[2003:64:a919:ce0d:e2cb:4eff:fe1b:b546])
	by mx.google.com with ESMTPSA id
	fm10sm11299827wib.7.2015.01.18.10.44.00 for <ptxdist@pengutronix.de>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sun, 18 Jan 2015 10:44:00 -0800 (PST)
Date: Sun, 18 Jan 2015 19:43:58 +0100
From: Alexander Aring <alex.aring@gmail.com>
Message-ID: <20150118184355.GC10822@omega>
References: <1419701935-28132-1-git-send-email-alex.aring@gmail.com>
	<1419701935-28132-3-git-send-email-alex.aring@gmail.com>
	<20150112143608.GA26436@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20150112143608.GA26436@pengutronix.de>
Subject: Re: [ptxdist] [PATCH bluetooth-next 2/4] openssl: allow to install
 openssl.cnf
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jan 12, 2015 at 03:36:08PM +0100, Michael Olbrich wrote:
> On Sat, Dec 27, 2014 at 06:38:53PM +0100, Alexander Aring wrote:
> > For doing some certificates magic the openssl tool requires some
> > openssl.cnf files. This patch adds an option to install the default one.
> > 
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  rules/openssl.in   | 5 +++++
> >  rules/openssl.make | 6 ++++++
> >  2 files changed, 11 insertions(+)
> > 
> > diff --git a/rules/openssl.in b/rules/openssl.in
> > index 096b398..d1c085d 100644
> > --- a/rules/openssl.in
> > +++ b/rules/openssl.in
> > @@ -28,4 +28,9 @@ config OPENSSL_BIN
> >  	help
> >  	  Whether to build and install OpenSSL binary.
> >  
> > +config OPENSSL_CNF
> > +	bool "install openssl.cnf"
> > +	help
> > +	  Install openssl.cnf config file.
> > +
> >  endif
> > diff --git a/rules/openssl.make b/rules/openssl.make
> > index 56cd6b7..ec32fe5 100644
> > --- a/rules/openssl.make
> > +++ b/rules/openssl.make
> > @@ -100,6 +100,12 @@ ifdef PTXCONF_OPENSSL_BIN
> >  	@$(call install_copy, openssl, 0, 0, 0755, -, \
> >  		/usr/bin/openssl)
> >  endif
> > +
> > +ifdef PTXCONF_OPENSSL_CNF
> > +	@$(call install_copy, openssl, 0, 0, 0644, -, \
> > +		/usr/lib/ssl/openssl.cnf)
> > +endif
> 
> I think we should always install this, unless there is a good reason to
> make this optional?
> 

One reason would be to save some space on the rootfs if this file isn't
really needed.

If we install this as default maybe this breaks some other workflow.
Yes.., I know every changes will breaks somebodys workflow.

Nevertheless I will send a new version of this patch which installs this
file per default.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de