Re: [ptxdist] [PATCH bluetooth-next 2/4] openssl: allow to install openssl.cnf

[Alexander Aring <alex.aring@gmail.com>]

On Mon, Jan 12, 2015 at 03:36:08PM +0100, Michael Olbrich wrote:
> On Sat, Dec 27, 2014 at 06:38:53PM +0100, Alexander Aring wrote:
> > For doing some certificates magic the openssl tool requires some
> > openssl.cnf files. This patch adds an option to install the default one.
> > 
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  rules/openssl.in   | 5 +++++
> >  rules/openssl.make | 6 ++++++
> >  2 files changed, 11 insertions(+)
> > 
> > diff --git a/rules/openssl.in b/rules/openssl.in
> > index 096b398..d1c085d 100644
> > --- a/rules/openssl.in
> > +++ b/rules/openssl.in
> > @@ -28,4 +28,9 @@ config OPENSSL_BIN
> >  	help
> >  	  Whether to build and install OpenSSL binary.
> >  
> > +config OPENSSL_CNF
> > +	bool "install openssl.cnf"
> > +	help
> > +	  Install openssl.cnf config file.
> > +
> >  endif
> > diff --git a/rules/openssl.make b/rules/openssl.make
> > index 56cd6b7..ec32fe5 100644
> > --- a/rules/openssl.make
> > +++ b/rules/openssl.make
> > @@ -100,6 +100,12 @@ ifdef PTXCONF_OPENSSL_BIN
> >  	@$(call install_copy, openssl, 0, 0, 0755, -, \
> >  		/usr/bin/openssl)
> >  endif
> > +
> > +ifdef PTXCONF_OPENSSL_CNF
> > +	@$(call install_copy, openssl, 0, 0, 0644, -, \
> > +		/usr/lib/ssl/openssl.cnf)
> > +endif
> 
> I think we should always install this, unless there is a good reason to
> make this optional?
> 

One reason would be to save some space on the rootfs if this file isn't
really needed.

If we install this as default maybe this breaks some other workflow.
Yes.., I know every changes will breaks somebodys workflow.

Nevertheless I will send a new version of this patch which installs this
file per default.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de