From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1YAgym-0005Sn-9Y
	for ptxdist@pengutronix.de; Mon, 12 Jan 2015 16:32:32 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1YAgym-0004eY-7j
	for ptxdist@pengutronix.de; Mon, 12 Jan 2015 16:32:32 +0100
Date: Mon, 12 Jan 2015 16:32:32 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20150112153232.GE26436@pengutronix.de>
References: <1420706596-10898-1-git-send-email-mh@newtec.dk>
	<20150108115820.GD31136@pengutronix.de>
	<CAKmi1bXYSL635+96ZmUfKaePevQbgUauXi0tYZqD_0TmM1qfwA@mail.gmail.com>
	<20150112145152.GC26436@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20150112145152.GC26436@pengutronix.de>
Subject: Re: [ptxdist] [oracle java7 jre 1/1] Added Oracles Java 7 JRE
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jan 12, 2015 at 03:51:52PM +0100, Michael Olbrich wrote:
> On Thu, Jan 08, 2015 at 01:36:19PM +0100, Martin Hejnfelt wrote:
> > 2015-01-08 12:58 GMT+01:00 Michael Olbrich <m.olbrich@pengutronix.de>:
> > >
> > > Any reason to use java7 and not java8?
> > 
> > Only reason is that I am developing for Java 7, and want to keep the
> > compatibility (or at least not introduce any issues, simply for
> > versioning). In my opinion, you should have both if anything.
> > 
> > >
> > >> +config ORACLE_JAVA7_JRE_TARGET_PREFIX
> > >> +     string
> > >> +     depends on ORACLE_JAVA7_JRE
> > >> +     default "/usr/lib/jvm"
> > >> +     prompt "PREFIX for JRE 7"
> > >> +     help
> > >> +       Where should the JRE be installed.
> > >
> > > Do we need this? I think we can just hardcode this path.
> > >
> > 
> > I agree, I'll change that.
> > 
> > >> +
> > >> +# ----------------------------------------------------------------------------
> > >> +# Get
> > >> +# ----------------------------------------------------------------------------
> > >> +
> > >> +$(ORACLE_JAVA7_JRE_SOURCE):
> > >> +     @$(call targetinfo)
> > >> +     wget --no-cookies --header "Cookie: oraclelicense=accept-securebackup-cookie" $(ORACLE_JAVA7_JRE_URL) -P $(SRCDIR)/
> > >
> > > No, this is more complex. I need to think about how to handle this
> > > correctly.
> > >
> > 
> > Yes it's more complex, but right now it's the only way I know to
> > download it automatically. Suggestions to change are welcome :)
> > 
> > Should I put up a new patch with the changes mentioned here, and the rest?
> 
> Just send it and I'll fix the download part once I know how I want to
> handle this.

I've pushed a change to handle this via the URL. Use:

ORACLE_JAVA7_JRE_URL	:= http://download.oracle.com/otn-pub/java/jdk/$(ORACLE_JAVA7_JRE_VERSION)-b01/$(ORACLE_JAVA7_JRE).$(ORACLE_JAVA7_JRE_SUFFIX);cookie:oraclelicense=accept-securebackup-cookie

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de