From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XteUn-0002hs-EI
	for ptxdist@pengutronix.de; Wed, 26 Nov 2014 16:27:09 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XteUn-0003ud-Cy
	for ptxdist@pengutronix.de; Wed, 26 Nov 2014 16:27:09 +0100
Date: Wed, 26 Nov 2014 16:27:09 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20141126152709.GI19664@pengutronix.de>
References: <1417003396-14336-1-git-send-email-list-09_ptxdist@tqsc.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1417003396-14336-1-git-send-email-list-09_ptxdist@tqsc.de>
Subject: Re: [ptxdist] [PATCH v2] systemd: add SYSTEMD_CPPFLAGS for local
 kernel headers
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, Nov 26, 2014 at 01:03:16PM +0100, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
> 
> systemd uses cpp to generate tables for keymappings. Without setting
> CPPFLAGS the toolchain headers will be used for generation but
> local kernel headers for compilation. This can break compile.
> 
> Since CPPFLAGS are implicitly used when calling compiler directly,
> we can drop the CFLAGS settings for local kernel headers.
> 
> tested with kernel 3.9
> 
> changes:
> 
> v2: drop SYSTEMD_CFLAGS, add this fact to the comments
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>

Thanks, applied.

Michael

> ---
>  rules/systemd.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/systemd.make b/rules/systemd.make
> index b0f7ce0..b2de3d7 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -41,7 +41,7 @@ SYSTEMD_CONF_ENV	:= \
>  
>  SYSTEMD_CONF_ENV += cc_cv_CFLAGS__flto=no
>  
> -SYSTEMD_CFLAGS		:= \
> +SYSTEMD_CPPFLAGS	:= \
>  	-I$(KERNEL_HEADERS_INCLUDE_DIR)
>  
>  #
> -- 
> 2.1.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de