[ptxdist] [PATCH v2] systemd: add SYSTEMD_CPPFLAGS for local kernel headers

[ptxdist] [PATCH v2] systemd: add SYSTEMD_CPPFLAGS for local kernel headers

[Markus Niebel]

From: Markus Niebel <Markus.Niebel@tq-group.com>

systemd uses cpp to generate tables for keymappings. Without setting
CPPFLAGS the toolchain headers will be used for generation but
local kernel headers for compilation. This can break compile.

Since CPPFLAGS are implicitly used when calling compiler directly,
we can drop the CFLAGS settings for local kernel headers.

tested with kernel 3.9

changes:

v2: drop SYSTEMD_CFLAGS, add this fact to the comments

Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 rules/systemd.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/systemd.make b/rules/systemd.make
index b0f7ce0..b2de3d7 100644
--- a/rules/systemd.make
+++ b/rules/systemd.make
@@ -41,7 +41,7 @@ SYSTEMD_CONF_ENV	:= \
 
 SYSTEMD_CONF_ENV += cc_cv_CFLAGS__flto=no
 
-SYSTEMD_CFLAGS		:= \
+SYSTEMD_CPPFLAGS	:= \
 	-I$(KERNEL_HEADERS_INCLUDE_DIR)
 
 #
-- 
2.1.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH v2] systemd: add SYSTEMD_CPPFLAGS for local kernel headers

[Michael Olbrich]

On Wed, Nov 26, 2014 at 01:03:16PM +0100, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
> 
> systemd uses cpp to generate tables for keymappings. Without setting
> CPPFLAGS the toolchain headers will be used for generation but
> local kernel headers for compilation. This can break compile.
> 
> Since CPPFLAGS are implicitly used when calling compiler directly,
> we can drop the CFLAGS settings for local kernel headers.
> 
> tested with kernel 3.9
> 
> changes:
> 
> v2: drop SYSTEMD_CFLAGS, add this fact to the comments
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>

Thanks, applied.

Michael

> ---
>  rules/systemd.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/systemd.make b/rules/systemd.make
> index b0f7ce0..b2de3d7 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -41,7 +41,7 @@ SYSTEMD_CONF_ENV	:= \
>  
>  SYSTEMD_CONF_ENV += cc_cv_CFLAGS__flto=no
>  
> -SYSTEMD_CFLAGS		:= \
> +SYSTEMD_CPPFLAGS	:= \
>  	-I$(KERNEL_HEADERS_INCLUDE_DIR)
>  
>  #
> -- 
> 2.1.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de