mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] systemd: add SYSTEMD_CPPFLAGS for kernel headers
Date: Wed, 26 Nov 2014 10:49:22 +0100	[thread overview]
Message-ID: <20141126094922.GC19664@pengutronix.de> (raw)
In-Reply-To: <1416921879-1834-1-git-send-email-list-09_ptxdist@tqsc.de>

On Tue, Nov 25, 2014 at 02:24:39PM +0100, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
> 
> systemd uses cpp to generate tables for keymappings. Without setting
> CPPFLAGS the toolchain headers will be used for generation but
> local kernel headers for compilation. This can break compile.
> 
> tested with kernel 3.9
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> ---
>  rules/systemd.make | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/rules/systemd.make b/rules/systemd.make
> index b0f7ce0..8c425e4 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -44,6 +44,9 @@ SYSTEMD_CONF_ENV += cc_cv_CFLAGS__flto=no
>  SYSTEMD_CFLAGS		:= \
>  	-I$(KERNEL_HEADERS_INCLUDE_DIR)
>  
> +SYSTEMD_CPPFLAGS	:= \
> +	-I$(KERNEL_HEADERS_INCLUDE_DIR)
> +

Hmmm, I think the correct solution is to set SYSTEMD_CPPFLAGS instead of
SYSTEMD_CFLAGS, right? Could you test that please? I don't a BSP right now,
where this fails, so I cannot test it.

Michael

>  #
>  # autoconf
>  #
> -- 
> 2.1.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-11-26  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 13:24 Markus Niebel
2014-11-26  9:49 ` Michael Olbrich [this message]
2014-11-26 12:03   ` Markus Niebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141126094922.GC19664@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox