From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XrpRQ-00069W-UX
	for ptxdist@pengutronix.de; Fri, 21 Nov 2014 15:44:08 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XrpRQ-0000pV-So
	for ptxdist@pengutronix.de; Fri, 21 Nov 2014 15:44:08 +0100
Date: Fri, 21 Nov 2014 15:44:08 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20141121144408.GQ19664@pengutronix.de>
References: <20141119115158.GJ16550@pengutronix.de>
	<1416553238-9308-1-git-send-email-post@lespocky.de>
	<1416553238-9308-2-git-send-email-post@lespocky.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1416553238-9308-2-git-send-email-post@lespocky.de>
Subject: Re: [ptxdist] [PATCH 2/2] libxml2: handle new ./configure options
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Fri, Nov 21, 2014 at 08:00:37AM +0100, Alexander Dahl wrote:
> 
> Signed-off-by: Alexander Dahl <post@lespocky.de>

Please squash this into the other patch.

> ---
>  rules/host-libxml2.make |    3 ++-
>  rules/libxml2.in        |   13 +++++++++++++
>  rules/libxml2.make      |    2 ++
>  3 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/host-libxml2.make b/rules/host-libxml2.make
> index c4a4b4b..2940c9b 100644
> --- a/rules/host-libxml2.make
> +++ b/rules/host-libxml2.make
> @@ -32,6 +32,7 @@ HOST_LIBXML2_ENV 	:= $(HOST_ENV)
>  HOST_LIBXML2_AUTOCONF	:= \
>  	$(HOST_AUTOCONF) \
>  	--disable-static \
> -	--without-iconv
> +	--without-iconv \
> +	--without-lzma

	--without-icu ??

>  
>  # vim: syntax=make
> diff --git a/rules/libxml2.in b/rules/libxml2.in
> index 72c1725..8642296 100644
> --- a/rules/libxml2.in
> +++ b/rules/libxml2.in
> @@ -6,6 +6,7 @@ menuconfig LIBXML2
>  	select LIBC_M
>  	select LIBC_DL	if LIBXML2_MODULES
>  	select ZLIB	if LIBXML2_ZLIB
> +	select XZ	if LIBXML2_LZMA
>  	select PYTHON	if LIBXML2_PYTHON
>  	help
>  	  Libxml2 is a XML C parser and toolkit. XML itself is a
> @@ -90,6 +91,12 @@ config LIBXML2_HTTP
>  	help
>  	  Add HTTP support.
>  
> +config LIBXML2_ICU
> +	bool
> +	prompt "ICU support"
> +	help
> +	  Add ICU support.

This requires icu to install icu-config to sysroot-cross.
I don't mind if you disable icu support unconditionally.
If someone needs it then they can extend the rule.

> +
>  config LIBXML2_ISO8859X
>  	bool
>  	default y
> @@ -264,4 +271,10 @@ config LIBXML2_ZLIB
>  	default y
>  	prompt "zlib (compression) support"
>  
> +config LIBXML2_LZMA
> +	bool
> +	prompt "lzma (compression) support"
> +	help
> +	  LZMA (compression) support with liblzma from XZ tools.
> +
>  endif
> diff --git a/rules/libxml2.make b/rules/libxml2.make
> index 3392e5e..6b5c05c 100644
> --- a/rules/libxml2.make
> +++ b/rules/libxml2.make
> @@ -54,8 +54,10 @@ LIBXML2_AUTOCONF := \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_HISTORY)-history \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_HTML)-html \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_HTTP)-http \
> +	--$(call ptx/wwo, PTXCONF_LIBXML2_ICU)-icu \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_ISO8859X)-iso8859x \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_LEGACY)-legacy \
> +	--$(call ptx/wwo, PTXCONF_LIBXML2_LZMA)-lzma \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_MEM_DEBUG)-mem-debug \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_MINIMUM)-minimum \
>  	--$(call ptx/wwo, PTXCONF_LIBXML2_OUTPUT)-output \

Nothing for this patch, but this really needs to be cleaned up. I think
several of those options should just be enable unconditionally...

Michael

> -- 
> 1.7.10.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de