From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Xoxd2-00088q-Ce
	for ptxdist@pengutronix.de; Thu, 13 Nov 2014 17:52:16 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1Xoxd2-0000K1-BI
	for ptxdist@pengutronix.de; Thu, 13 Nov 2014 17:52:16 +0100
Date: Thu, 13 Nov 2014 17:52:16 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20141113165216.GU30196@pengutronix.de>
References: <1414367273-31302-1-git-send-email-apr@cn-eng.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1414367273-31302-1-git-send-email-apr@cn-eng.de>
Subject: Re: [ptxdist] [PATCH] dnsmasq: /etc/init.d/dnsmasq: fix erroneous
 "already running" message
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Oct 27, 2014 at 12:47:53AM +0100, Andreas Pretzsch wrote:
> Init script reports "already running" / "not running" based on
> existence of PID file. Test in start case is inverted. Fix this.
> Originally introduced in 1ca15292d20f8f73654ceba4b72d37f5bdb1cecf
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>

Thanks, applied.

Michael

> ---
>  generic/etc/init.d/dnsmasq | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/generic/etc/init.d/dnsmasq b/generic/etc/init.d/dnsmasq
> index e9ef8c1..6e6aa5d 100644
> --- a/generic/etc/init.d/dnsmasq
> +++ b/generic/etc/init.d/dnsmasq
> @@ -9,7 +9,7 @@ PIDFILE=/var/run/dnsmasq.pid
>  case $1 in
>  
>  	start)
> -		test -e $PIDFILE || echo "already running"
> +		test -e $PIDFILE && echo "already running"
>  		echo "dnsmasq starting"
>  		/usr/sbin/dnsmasq
>  		;;
> -- 
> 2.1.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de