mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] dnsmasq: /etc/init.d/dnsmasq: fix erroneous "already running" message
@ 2014-10-26 23:47 Andreas Pretzsch
  2014-11-13 16:52 ` Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Pretzsch @ 2014-10-26 23:47 UTC (permalink / raw)
  To: ptxdist

Init script reports "already running" / "not running" based on
existence of PID file. Test in start case is inverted. Fix this.
Originally introduced in 1ca15292d20f8f73654ceba4b72d37f5bdb1cecf

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
 generic/etc/init.d/dnsmasq | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/generic/etc/init.d/dnsmasq b/generic/etc/init.d/dnsmasq
index e9ef8c1..6e6aa5d 100644
--- a/generic/etc/init.d/dnsmasq
+++ b/generic/etc/init.d/dnsmasq
@@ -9,7 +9,7 @@ PIDFILE=/var/run/dnsmasq.pid
 case $1 in
 
 	start)
-		test -e $PIDFILE || echo "already running"
+		test -e $PIDFILE && echo "already running"
 		echo "dnsmasq starting"
 		/usr/sbin/dnsmasq
 		;;
-- 
2.1.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [PATCH] dnsmasq: /etc/init.d/dnsmasq: fix erroneous "already running" message
  2014-10-26 23:47 [ptxdist] [PATCH] dnsmasq: /etc/init.d/dnsmasq: fix erroneous "already running" message Andreas Pretzsch
@ 2014-11-13 16:52 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2014-11-13 16:52 UTC (permalink / raw)
  To: ptxdist

On Mon, Oct 27, 2014 at 12:47:53AM +0100, Andreas Pretzsch wrote:
> Init script reports "already running" / "not running" based on
> existence of PID file. Test in start case is inverted. Fix this.
> Originally introduced in 1ca15292d20f8f73654ceba4b72d37f5bdb1cecf
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>

Thanks, applied.

Michael

> ---
>  generic/etc/init.d/dnsmasq | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/generic/etc/init.d/dnsmasq b/generic/etc/init.d/dnsmasq
> index e9ef8c1..6e6aa5d 100644
> --- a/generic/etc/init.d/dnsmasq
> +++ b/generic/etc/init.d/dnsmasq
> @@ -9,7 +9,7 @@ PIDFILE=/var/run/dnsmasq.pid
>  case $1 in
>  
>  	start)
> -		test -e $PIDFILE || echo "already running"
> +		test -e $PIDFILE && echo "already running"
>  		echo "dnsmasq starting"
>  		/usr/sbin/dnsmasq
>  		;;
> -- 
> 2.1.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-13 16:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-26 23:47 [ptxdist] [PATCH] dnsmasq: /etc/init.d/dnsmasq: fix erroneous "already running" message Andreas Pretzsch
2014-11-13 16:52 ` Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox